Add GitHub Action for deploy #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesmile
force-pushed
the
github_action_deploy
branch
from
d8d6c59 to
e80ab77
Compare
kylesmile
had a problem deploying
to
github-pages
GitHub Actions
Failure
kylesmile
temporarily deployed
to
github-pages
GitHub Actions
Inactive
BenCreating
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5.
This adds a build step to generate an importmap, which allows bringing in dependencies from npm without needing to rely on a CDN. I also updated the deploy.yml to make sure it is setting up and installing the correct Node version, as well as making a few other small changes to follow best practices (e.g.,
npm ciinstead ofnpm install).