fix: Improve upsert_index to only drop+rebuild if there is no matching & valid index
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effron
reviewed
Dec 10, 2025
| execute("SET statement_timeout TO #{pg_seconds(statement_timeout) || 'DEFAULT'};") | ||
| execute("SET lock_timeout TO #{pg_seconds(lock_timeout) || 'DEFAULT'};") | ||
| when 'MySQL', 'MariaDB' | ||
| when "MySQL", "Mysql2" |
Member
Author
There was a problem hiding this comment.
Until I enabled "warn" logs for the migration phase of testing, I didn't notice the fact that we weren't applying statement timeouts to mysql, because "Mysql2" is the actual adapter name.
Member
Author
There was a problem hiding this comment.
Could probably use a harder testing constriant/guarantee there, but there's so much of this new migration/DB-testing layer that I want to extract & more directly test as its own thing 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for proactively adding indexes out of band, so that the migrator will no-op and complete quickly. For very large tables this may be necessary to stay within constraints of synchronous deployment steps (e.g. a timeout on migration processes).
I also adjusted test logger setup so that it relies entirely on log levels, and will log out migration warnings even if debug logging is turned off for the rest of the test suite.
/no-platform