Skip to content

Conversation

@smudge
Copy link
Member

@smudge smudge commented Jan 5, 2026

@migration_start was never getting set, and there wasn't any code exercising the non-happy path for these migrations.

This also bumps the version to 2.0.1

/no-platform

@smudge smudge requested a review from effron January 5, 2026 19:46
effron
effron previously approved these changes Jan 5, 2026
Copy link
Contributor

@effron effron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM

Copy link
Contributor

@effron effron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM

Copy link
Contributor

@effron effron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM

@smudge smudge merged commit d8a44e1 into Betterment:main Jan 5, 2026
25 checks passed
@smudge smudge deleted the fix-migration-lock-loop branch January 5, 2026 19:57
@smudge smudge changed the title fix: Ensure that migration lock timeout loop works as expected. fix: Ensure that migration lock timeout loop does not bail after the first timeout. Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants