fix: Allow statement timeouts on index creation to retry (within migration wait timeout) #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smudge
force-pushed
the
fix-migration-lock-loop
branch
from
35445b9 to
aa67eb5
Compare
…within migration wait timeout)
smudge
force-pushed
the
fix-migration-lock-loop
branch
from
aa67eb5 to
27c79b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
with_retry_loophad wrapped the "drop" & "add" operations separately. This is fine in the case of lock timeouts, as it will retry until it acquires a lock as expected.However, if
add_indexexperiences a statement timeout (and we have not yet exceeded the migration'swait_timeout), it would fail to retry if (on PostgreSQL, w/ the:concurrentlyopt) an invalid index was left behind. The operation should first remove the invalid index before attempting anotheradd_indexcall, and that's what this PR addresses./no-platform