Open
Conversation
a6cd13b to
9e9e7bf
Compare
Contributor
|
Hi @jo-mueller , thanks, I will check this over the weekend. I like the idea! I did not look at the code yet, but just remember to make this backwards compatible for now as other plugins also depend on this. One idea is to let each selector button optionally enabled or not, at least internally. This way, each plugin built on top can choose which features to show or have in the interface. Similar to what I did with the highlighting feature. |
Contributor
Author
|
@zoccoler a bit late but I think what you are describing should be the case. The new selector is just another entry in the list of selectors that can be enabled/disabled with the same shared behavior like the others 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @zoccoler, just an extension to the existing selectors: This PR introduces the picker selector, which - as the name suggests - allows to click/select individual points.
I am thinking of adding a callback here that jumps to the last selected object on double-click with the picker-selector enabled, do you think that's a reasonable thing to do? I would then deprecate the highlighting in favor of this approach. I would try to write a pyqtgraph backend next and that would definitely be a bit easier with one less visual layer (color, size, alpha, edge color) to track 🙈