update package size requirement #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FWIW: I agree with this change |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the maximum package tarball size limit for Bioconductor Software packages from 5 MB to 10 MB.
- Updates the default package size limit from 5 MB to 10 MB in the
checkPackageSizefunction - Updates documentation to reflect the new 10 MB limit
- Adds NEWS entry documenting the change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| R/checks.R | Updates the default size parameter in checkPackageSize() from 5 to 10 and improves the comment clarity |
| vignettes/BiocCheck.Rmd | Updates documentation to reflect the new 10 MB package size limit |
| NEWS | Adds changelog entry for version 1.48.0 noting the package size limit increase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are submitting a pull request to
BiocCheckplease follow theinstructions.
The presentation includes steps for forking, creating a working branch, and
useful related information.
For a successful merge, the following steps are required:
R CMD build&R CMD checkon Bioconductor develList a reviewer in the Pull Request (either @LiNk-NY, @lshep).
Reviewers will make sure to
Comment,ApproveorRequest changes.We highly recommend the use of the Bioconductor devel docker image described
on the Bioconductor website.
If you have any questions, please get in touch with the Bioconductor core team
on the Bioconductor Community Slack.