model-wrappers, discretization of sigma_hat #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them access to a generic inner_model
…can make k-diffusion wrapper compatible classes (e.g. which delegate to a k-diffusion wrapper rather than inheriting from one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: for a cleaner diff: merge-base of this PR is set to an unrelated branch in my repository, rather than upstreaming to crowsonkb/k-diffusion. because this branch is downstream of my Mac fixes and miscellany.
I made the model wrapper generic, so that you get auto-completion from
inner_model:somewhat worried about this:
since using
quantize=Trueandchurn=0.: we should expect this to be a no-op.yet, there's a slight difference (see nose) when we apply this roundtrip to the sigma (left = usual, right = discretization):
when churn>0, the difference is, uh, more dramatic (left = discretized, churn=0; right = discretized, churn = 0.1):
churn>0 does work if I remove the discretization (left = non-discretized, churn=0; right = non-discretized, churn = 0.1):
