Merged
Conversation
justing-bq
force-pushed
the
macos-arm-ci
branch
10 times, most recently
from
e80761c to
61ddbac
Compare
justing-bq
force-pushed
the
macos-arm-ci
branch
7 times, most recently
from
e3f8574 to
de82fe7
Compare
justing-bq
force-pushed
the
macos-arm-ci
branch
2 times, most recently
from
a03d5b0 to
3a5c41b
Compare
alinaliBQ
reviewed
Nov 26, 2025
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
Great work! I will give a detailed review when PR is ready :)
justing-bq
force-pushed
the
macos-arm-ci
branch
4 times, most recently
from
c73d93f to
c7a7454
Compare
alinaliBQ
reviewed
Nov 27, 2025
justing-bq
force-pushed
the
macos-arm-ci
branch
2 times, most recently
from
cb85c06 to
b4113b7
Compare
justing-bq
force-pushed
the
macos-arm-ci
branch
2 times, most recently
from
9be8637 to
f85dba2
Compare
alinaliBQ
force-pushed
the
apache-odbc
branch
from
7df62c8 to
ba3a999
Compare
justing-bq
force-pushed
the
macos-arm-ci
branch
4 times, most recently
from
0389ca8 to
36c6474
Compare
alinaliBQ
reviewed
Dec 2, 2025
justing-bq
changed the title
alinaliBQ
reviewed
Dec 2, 2025
justing-bq
force-pushed
the
macos-arm-ci
branch
from
36c6474 to
2008b72
Compare
alinaliBQ
reviewed
Dec 2, 2025
justing-bq
force-pushed
the
macos-arm-ci
branch
2 times, most recently
from
a3115a3 to
c9eafcc
Compare
alinaliBQ
reviewed
Dec 2, 2025
| } | ||
|
|
||
| TYPED_TEST(ErrorsTest, TestSQLErrorInputData) { | ||
| TYPED_TEST(ErrorsOdbcV2Test, TestSQLErrorInputData) { |
There was a problem hiding this comment.
JFYI - this test still fails on my local machine. I think implementing SQLError might fix this. No changes needed for this comment in this PR
justing-bq
force-pushed
the
macos-arm-ci
branch
from
c9eafcc to
10664ac
Compare
justing-bq
force-pushed
the
macos-arm-ci
branch
from
0b6a5af to
7c1f195
Compare
alinaliBQ
reviewed
Dec 3, 2025
| SQLGetData(this->stmt, 27, SQL_C_DEFAULT, &wvarchar_val, buf_len, &ind)); | ||
| SQLGetData(this->stmt, 27, SQL_C_WCHAR, &wvarchar_val, buf_len, &ind)); | ||
| EXPECT_EQ(L'你', wvarchar_val[0]); | ||
| EXPECT_EQ(L'好', wvarchar_val[1]); |
justing-bq
force-pushed
the
macos-arm-ci
branch
from
7c1f195 to
d0444f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?