Conversation
L0Lmaker
force-pushed
the
rithin/an-1208-gremlin-js-coverage
branch
from
b20deda to
135a30a
Compare
| "features": "npm run features-graphson30 && npm run features-graphbinary", | ||
| "features-graphson30": "cross-env CLIENT_MIMETYPE='application/vnd.gremlin-v3.0+json' cucumber-js --require test/cucumber ../../../../../gremlin-test/features/", | ||
| "features-graphbinary": "cross-env CLIENT_MIMETYPE='application/vnd.graphbinary-v1.0' cucumber-js --require test/cucumber ../../../../../gremlin-test/features/", | ||
| "features-docker": "npm run features-graphson30-docker && npm run features-graphbinary-docker", |
There was a problem hiding this comment.
Aren't these the commands for running this in Docker?
There was a problem hiding this comment.
oops, these are unnecessary, will remove them
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #24 +/- ##
===========================================
+ Coverage 63.58% 71.45% +7.86%
===========================================
Files 23 81 +58
Lines 3636 6656 +3020
===========================================
+ Hits 2312 4756 +2444
- Misses 1145 1721 +576
Partials 179 179
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| "lockfileVersion": 1, | ||
| "requires": true, | ||
| "dependencies": { | ||
| "@ampproject/remapping": { |
There was a problem hiding this comment.
Wondering why the package-lock file is adding a large chunk of code again, is it the node version?
There was a problem hiding this comment.
installed with same node and npm version, the changes refer to the dependencies and sub-dependencies of the nyc dependency that is added in this PR
There was a problem hiding this comment.
added 100 dependencies, but it's ok for node world %)
3 participants
No description provided.