Skip to content

TINKERPOP-3017 Added AnonymousTraversalSource.with()#99

Closed
andreachild wants to merge 4 commits intoBit-Quill:4.0-backportfrom
andreachild:achild-backport-TINKERPOP-3017
Closed

TINKERPOP-3017 Added AnonymousTraversalSource.with()#99
andreachild wants to merge 4 commits intoBit-Quill:4.0-backportfrom
andreachild:achild-backport-TINKERPOP-3017

Conversation

@andreachild
Copy link

Replaces withEmbedded() and withRemote() and removes the long deprecated withGraph(). A single unified with() removes the need to check the object being given to the AnonymousTraversalSource to decide which method to use. Can't remember why that split was used in the first place. This should make it easier to explain how to use the AnonymousTraversalSource in the first place, requires a bit less typing and simply streamlines the API.

This is a back port of apache#2366 from master (4.0) without the CHANGELOG.asciidoc and release-4.x.x.asciidoc changes as there is not yet a place for this content in the back port branch.

Replaces withEmbedded() and withRemote() and removes the long deprecated withGraph(). A single unified with() removes the need to check the object being given to the AnonymousTraversalSource to decide which method to use. Can't remember why that split was used in the first place. This should make it easier to explain how to use the AnonymousTraversalSource in the first place, requires a bit less typing and simply streamlines the API.
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (4.0-backport@430cc36). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...in/process/traversal/AnonymousTraversalSource.java 25.00% 9 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             4.0-backport      #99   +/-   ##
===============================================
  Coverage                ?   76.35%           
  Complexity              ?    13230           
===============================================
  Files                   ?     1061           
  Lines                   ?    61574           
  Branches                ?     7343           
===============================================
  Hits                    ?    47013           
  Misses                  ?    12039           
  Partials                ?     2522           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreachild andreachild marked this pull request as ready for review March 11, 2025 22:10
@Cole-Greer
Copy link

Cole-Greer commented Mar 11, 2025

@andreachild
Copy link
Author

There's some missing docs changes in https://github.com/andreachild/tinkerpop/blob/ba60917d477f3f0aaa7e20cadbe64418361ed86c/docs/src/reference/gremlin-variants.asciidoc?plain=1#L2131-L2153

Otherwise, LGTM

Thanks for catching that, I have fixed the python references to with.

@andreachild
Copy link
Author

Closing and will reopen new PR against 3.8-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants