TINKERPOP-3017 Added AnonymousTraversalSource.with()#99
TINKERPOP-3017 Added AnonymousTraversalSource.with()#99andreachild wants to merge 4 commits intoBit-Quill:4.0-backportfrom
Conversation
Replaces withEmbedded() and withRemote() and removes the long deprecated withGraph(). A single unified with() removes the need to check the object being given to the AnonymousTraversalSource to decide which method to use. Can't remember why that split was used in the first place. This should make it easier to explain how to use the AnonymousTraversalSource in the first place, requires a bit less typing and simply streamlines the API.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.0-backport #99 +/- ##
===============================================
Coverage ? 76.35%
Complexity ? 13230
===============================================
Files ? 1061
Lines ? 61574
Branches ? 7343
===============================================
Hits ? 47013
Misses ? 12039
Partials ? 2522 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There's some missing docs changes in https://github.com/andreachild/tinkerpop/blob/ba60917d477f3f0aaa7e20cadbe64418361ed86c/docs/src/reference/gremlin-variants.asciidoc?plain=1#L2131-L2153 Otherwise, LGTM |
Thanks for catching that, I have fixed the python references to |
|
Closing and will reopen new PR against 3.8-dev |
Replaces withEmbedded() and withRemote() and removes the long deprecated withGraph(). A single unified with() removes the need to check the object being given to the AnonymousTraversalSource to decide which method to use. Can't remember why that split was used in the first place. This should make it easier to explain how to use the AnonymousTraversalSource in the first place, requires a bit less typing and simply streamlines the API.
This is a back port of apache#2366 from master (4.0) without the CHANGELOG.asciidoc and release-4.x.x.asciidoc changes as there is not yet a place for this content in the back port branch.