Refactor Network Window: Change Network Wifi List from ListCustomButton to a QListView
#135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wifiConnectivityWindow.ui: change horizontalLayout to a vertical layout with a listview and a vertical scrollbar wifiConnectivityWindow.py: generated file from QtDesigner with some optimizations Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| RF50_DATASHEET_PAGE = ( | ||
| "https://www.blockstec.com/assets/downloads/rf50_datasheet.pdf" | ||
| ) | ||
| RF50_DATASHEET_PAGE = "https://www.blockstec.com/assets/downloads/rf50_datasheet.pdf" |
| "fan": QtGui.QPixmap(":/fan_related/media/btn_icons/fan.svg"), | ||
| } | ||
|
|
||
| self.panel.cp_z_tilt_btn.clicked.connect(lambda: self.handle_ztilt()) |
| wifi_toggle = self.panel.wifi_button.toggle_button | ||
| hotspot_toggle = self.panel.hotspot_button.toggle_button | ||
|
|
||
| blockers = ( |
| def _run_command(self, command): | ||
|
|
||
| def _run_command(self, command: str): |
| """Schedule a reschedule timer""" | ||
| try: | ||
| self._delayed_action_timer.timeout.disconnect() | ||
| except TypeError: |
|
|
||
| def get_file_loc(filename) -> pathlib.Path: | ||
| ... | ||
| def get_file_loc(filename) -> pathlib.Path: ... |
| # return | ||
| # self._configure_option_cards(_keys) | ||
| if isinstance(config, list): | ||
| ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
lib/panels/networkWindow.pyListCustomButtonto aQListViewusing MVC architectureBuildNetworkListfromQtCore.QThreadto aQtCore.QObjectthat uses aQThreadPoolto runNetworkScanRunnabletasks periodically. with aQTimerto trigger scans. Prevents overlapping scans by tracking whether a scan is already in progress.Screenshots
Before
After
Future Work
Ui_wifi_stacked_pageCo-Authors
Co‑author: @Robert0Mart
Co‑author: @claudiobrinca