This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Initial implementation of converter bin to SONATA reports#32
Merged
jorblancoa merged 10 commits intomasterfrom Nov 3, 2022
Merged
Initial implementation of converter bin to SONATA reports#32jorblancoa merged 10 commits intomasterfrom
jorblancoa merged 10 commits intomasterfrom
Conversation
Collaborator
jorblancoa
commented
Jul 12, 2022
jorblancoa
commented
- Read .bbp with reportinglib ReadManager
- Write SONATA report using write_buffered_data()
- Read .bbp with reportinglib ReadManager - Write using write_buffered_data()
- Write several timesteps at a time (default = 10) - Avoid creation of innecesary std::vector
pramodk
reviewed
Oct 4, 2022
Contributor
pramodk
left a comment
pramodk
left a comment
There was a problem hiding this comment.
looks good! I took a quick look and mostly added nitpicks / minor suggestions.
Write 1 frame per iteration
- CamelCase to snake_case - file name changes
pramodk
reviewed
Oct 12, 2022
Contributor
pramodk
left a comment
pramodk
left a comment
There was a problem hiding this comment.
one minor question about new/deleted otherwise looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.