Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

NSETM-1298 entity api POC#138

Merged
joni-herttuainen merged 55 commits intomasterfrom
NSETM-1298_entity_api_poc
Aug 26, 2022
Merged

NSETM-1298 entity api POC#138
joni-herttuainen merged 55 commits intomasterfrom
NSETM-1298_entity_api_poc

Conversation

@GianlucaFicarelli
Copy link
Contributor

This PR is a draft to keep track of the changes done in NSETM-1298.
It should not be merged until it's clarified if it can be useful, or eventually deleted together with the branch.

@GianlucaFicarelli GianlucaFicarelli marked this pull request as draft June 9, 2021 16:20
@mgeplf mgeplf self-requested a review June 10, 2021 12:42
@joni-herttuainen joni-herttuainen force-pushed the NSETM-1298_entity_api_poc branch from 7439c6e to 704212d Compare March 17, 2022 11:33
@joni-herttuainen joni-herttuainen force-pushed the NSETM-1298_entity_api_poc branch from 9abe480 to 23e46b3 Compare July 27, 2022 15:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #138 (34d349c) into master (bb5f643) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 34d349c differs from pull request most recent head 7140331. Consider uploading reports for the commit 7140331 to get more accurate results

@@            Coverage Diff             @@
##            master      #138    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           25        31     +6     
  Lines         1957      2242   +285     
==========================================
+ Hits          1957      2242   +285     
Flag Coverage Δ
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bluepysnap/nexus/__init__.py 100.00% <100.00%> (ø)
bluepysnap/nexus/connector.py 100.00% <100.00%> (ø)
bluepysnap/nexus/core.py 100.00% <100.00%> (ø)
bluepysnap/nexus/entity.py 100.00% <100.00%> (ø)
bluepysnap/nexus/factory.py 100.00% <100.00%> (ø)
bluepysnap/nexus/tools.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joni-herttuainen
Copy link
Contributor

This PR is now split in three PRs: this one, #163 and #164 . Everything should be up-to-date and ready to review.

@joni-herttuainen joni-herttuainen marked this pull request as ready for review August 17, 2022 11:04
Joni Herttuainen and others added 24 commits August 25, 2022 18:20
* updated docstrings
* added nexus-forge documentation to the docs
* updated README.rst
* updated CHANGELOG.rst
@joni-herttuainen joni-herttuainen force-pushed the NSETM-1298_entity_api_poc branch from c3051a7 to 34d349c Compare August 25, 2022 16:30
Copy link
Contributor

@joni-herttuainen joni-herttuainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes accerding to review, also rebased on to master

Copy link
Contributor

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 🎉 🎉

@joni-herttuainen joni-herttuainen merged commit b3342d0 into master Aug 26, 2022
@joni-herttuainen joni-herttuainen deleted the NSETM-1298_entity_api_poc branch August 26, 2022 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants