-
Notifications
You must be signed in to change notification settings - Fork 1
New Crowdin updates #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crowdin updates #71
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Russian and Spanish locale files to reflect a change in the translation key for the selected token accessibility label. The parameterized translation key "Selected token: {sym}" is being deprecated in favor of a simpler "Selected token: " key, likely because the token symbol is now handled differently in the code.
- New translation entry added for
"Selected token: "(without parameter) - Previous parameterized translation entry
"Selected token: {sym}"marked as obsolete - Revision dates updated to reflect the changes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/cowswap-frontend/src/locales/ru-RU.po | Updates Russian locale with new translation key and marks old parameterized version as obsolete |
| apps/cowswap-frontend/src/locales/es-ES.po | Updates Spanish locale with new translation key and marks old parameterized version as obsolete |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| msgid "Selected token: {sym}" | ||
| msgstr "Выбранный токен: {sym}" | ||
| #~ msgid "Selected token: {sym}" | ||
| #~ msgstr "Selected token: {sym}" |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The obsolete translation entry is incorrectly using English text instead of preserving the original Russian translation. The msgstr should be \"Выбранный токен: {sym}\" to maintain the translation history correctly.
| #~ msgstr "Selected token: {sym}" | |
| #~ msgstr "Выбранный токен: {sym}" |
| msgid "Selected token: {sym}" | ||
| msgstr "Token seleccionado: {sym}" | ||
| #~ msgid "Selected token: {sym}" | ||
| #~ msgstr "Selected token: {sym}" |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The obsolete translation entry is incorrectly using English text instead of preserving the original Spanish translation. The msgstr should be \"Token seleccionado: {sym}\" to maintain the translation history correctly.
| #~ msgstr "Selected token: {sym}" | |
| #~ msgstr "Token seleccionado: {sym}" |
|
|
||
| #: apps/cowswap-frontend/src/common/pure/CurrencySelectButton/index.tsx | ||
| msgid "Selected token: " | ||
| msgstr "" |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new translation entry has an empty msgstr, meaning it will fall back to English. This should be translated to Russian: msgstr \"Выбранный токен: \"
| msgstr "" | |
| msgstr "Выбранный токен: " |
|
|
||
| #: apps/cowswap-frontend/src/common/pure/CurrencySelectButton/index.tsx | ||
| msgid "Selected token: " | ||
| msgstr "" |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new translation entry has an empty msgstr, meaning it will fall back to English. This should be translated to Spanish: msgstr \"Token seleccionado: \"
| msgstr "" | |
| msgstr "Token seleccionado: " |
bb9417c
into
feat/internationalization-setup-for-swap-cow-fi
No description provided.