Skip to content

Conversation

@gabitoesmiapodo
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings November 3, 2025 18:39
@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cowswap Building Building Preview Comment Nov 3, 2025 6:57pm

@github-actions
Copy link

github-actions bot commented Nov 3, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Russian and Spanish locale files to reflect a change in the translation key for the selected token accessibility label. The parameterized translation key "Selected token: {sym}" is being deprecated in favor of a simpler "Selected token: " key, likely because the token symbol is now handled differently in the code.

  • New translation entry added for "Selected token: " (without parameter)
  • Previous parameterized translation entry "Selected token: {sym}" marked as obsolete
  • Revision dates updated to reflect the changes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Updates Russian locale with new translation key and marks old parameterized version as obsolete
apps/cowswap-frontend/src/locales/es-ES.po Updates Spanish locale with new translation key and marks old parameterized version as obsolete

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

msgid "Selected token: {sym}"
msgstr "Выбранный токен: {sym}"
#~ msgid "Selected token: {sym}"
#~ msgstr "Selected token: {sym}"
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation entry is incorrectly using English text instead of preserving the original Russian translation. The msgstr should be \"Выбранный токен: {sym}\" to maintain the translation history correctly.

Suggested change
#~ msgstr "Selected token: {sym}"
#~ msgstr "Выбранный токен: {sym}"

Copilot uses AI. Check for mistakes.
msgid "Selected token: {sym}"
msgstr "Token seleccionado: {sym}"
#~ msgid "Selected token: {sym}"
#~ msgstr "Selected token: {sym}"
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation entry is incorrectly using English text instead of preserving the original Spanish translation. The msgstr should be \"Token seleccionado: {sym}\" to maintain the translation history correctly.

Suggested change
#~ msgstr "Selected token: {sym}"
#~ msgstr "Token seleccionado: {sym}"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/common/pure/CurrencySelectButton/index.tsx
msgid "Selected token: "
msgstr ""
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new translation entry has an empty msgstr, meaning it will fall back to English. This should be translated to Russian: msgstr \"Выбранный токен: \"

Suggested change
msgstr ""
msgstr "Выбранный токен: "

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/common/pure/CurrencySelectButton/index.tsx
msgid "Selected token: "
msgstr ""
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new translation entry has an empty msgstr, meaning it will fall back to English. This should be translated to Spanish: msgstr \"Token seleccionado: \"

Suggested change
msgstr ""
msgstr "Token seleccionado: "

Copilot uses AI. Check for mistakes.
@gabitoesmiapodo gabitoesmiapodo merged commit bb9417c into feat/internationalization-setup-for-swap-cow-fi Nov 3, 2025
2 of 5 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch November 3, 2025 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants