Skip to content

fix(redisdb): correct kwargs None check in RedisDB.__init__ #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhouxinfei wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(redisdb): correct kwargs None check in RedisDB.__init__ #307

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32a94ef
Merge pull request #1 from Boris-code/master
zhouxinfei Apr 16, 2024
1390fcd
Merge branch 'Boris-code:master' into master
zhouxinfei Feb 2, 2026
4bc1f7a
fix: 修复 RedisDB kwargs 问题
Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feapder/db/redisdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def __init__(
user_pass = setting.REDISDB_USER_PASS
if service_name is None:
service_name = setting.REDISDB_SERVICE_NAME
if kwargs is None:
if not kwargs:
Copy link

@MonkeyCode-AI MonkeyCode-AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

💡 if not kwargs 会覆盖调用方显式传入的空字典语义（若需要区分“未提供”与“提供但为空”）

当前签名使用 **kwargs，调用方无法传入 None，只能传入若干关键字参数；因此 kwargs 为空通常代表“未提供额外参数”，回退到 setting.REDISDB_KWARGS 是合理的。但如果未来希望支持 RedisDB(**{}) 这类“显式要求不使用默认 kwargs”的语义（尽管当前也等价于没传），if not kwargs 会强制回退到全局默认，无法表达“空覆盖”。这属于产品/接口语义选择问题，不一定要改。

建议: 保持当前实现即可；若要区分语义，可改用显式参数（例如 kwargs: dict | None = None）而不是 **kwargs，并在内部合并/覆盖。

Suggested change
if not kwargs:

kwargs = setting.REDISDB_KWARGS

self._is_redis_cluster = False
Expand Down