Skip to content

External Map Deeplinks#116

Open
br-nchiu wants to merge 1 commit intoBottleRocketStudios:mainfrom
br-nchiu:main
Open

External Map Deeplinks#116
br-nchiu wants to merge 1 commit intoBottleRocketStudios:mainfrom
br-nchiu:main

Conversation

@br-nchiu
Copy link
Contributor

New pull request to resolve merge conflicts

@br-nchiu br-nchiu requested a review from a team as a code owner April 12, 2022 16:54
Copy link
Contributor

@wmcginty wmcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be interested to hear other's thoughts on this - but I don't think this belongs in UtiliKit. The times a user would need something like this is much more infrequent than view controller configuration, or collection view usage, etc.

That isn't to say I don't think this is valuable to have, I'd just much rather see this be a standalone swift package or Cocoapod that is fully geared toward Map URL building.

@br-nchiu
Copy link
Contributor Author

I'd be interested to hear other's thoughts on this - but I don't think this belongs in UtiliKit. The times a user would need something like this is much more infrequent than view controller configuration, or collection view usage, etc.

That isn't to say I don't think this is valuable to have, I'd just much rather see this be a standalone swift package or Cocoapod that is fully geared toward Map URL building.

Agreed, I think "All the things you're tired of writing." is a bit too broad and is making this a catch all. There are several pieces that might be better as stand alone swift packages- external maps deeplinks, scrolling page control (deprecated), active labels, etc- pretty much anything that isn't a broad use case extension of a type found in Foundation/UIKit/SwiftUI.

@br-tyler-milner
Copy link
Contributor

I could see this being its own separate repo/package. Really, we should probably extract a bunch of stuff out of UtiliKit per @br-nchiu's point. The other option would be to continue to push code here, but utilize subspecs to allow clients to only pull in the functionality they're interested in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants