Draft
Conversation
Generated by 🚫 Danger Swift against ae1236a |
wmcginty
approved these changes
Jun 19, 2020
| To find if a string contains potentially objectionable input, create a filter and place a query. | ||
|
|
||
| ``` swift | ||
| // TODO |
Contributor
There was a problem hiding this comment.
Looks like we're missing the basic how-to from here.
Contributor
Author
There was a problem hiding this comment.
Whoops!
I guess at least I put in the todo. I wrote that before I decided how I'd implement it. :)
| import UtiliKit | ||
| import XCTest | ||
|
|
||
| class LanguageFilterTests: XCTestCase { |
Contributor
There was a problem hiding this comment.
Well this is certainly a... unique... set of tests 😄
wmcginty
requested changes
Jun 19, 2020
Contributor
wmcginty
left a comment
wmcginty
left a comment
There was a problem hiding this comment.
Oops - I think we also need to update the Podspec to define the new subspec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a language filter mechanism. This will allow developers to quickly implement light client-side filtering for a selection of words that are vulgar, hateful, or disrespectful.
Anyone interested in investigating the selected list of words can do so by rot13ing against the source array, but I didn't want the list in plaintext.
Note that this will not pass CI yet, because the screenshot library's current version isn't compatible with the latest Xcode. There's an open PR for that, which I incorporated locally.