2756 - add filtering of series list in exercise group #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xercise group by id
|
Frontend test coverage: 45.59% 🤷♂️ Did not change |
umedvedev
reviewed
Sep 30, 2025
umedvedev
reviewed
Sep 30, 2025
umedvedev
reviewed
Sep 30, 2025
umedvedev
reviewed
Sep 30, 2025
src/test/kotlin/com/epam/brn/integration/repo/SeriesRepositoryTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/com/epam/brn/integration/repo/SeriesRepositoryTest.kt
Outdated
Show resolved
Hide resolved
|
Frontend test coverage: 45.59% 🤷♂️ Did not change |
|
Frontend test coverage: 45.59% 🤷♂️ Did not change |
|
ElenaSpb
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2756
I added integration tests for
SeriesRepositoryin order to check if new JPA methods added in #2595 are returning only active series. I t turns out that this new methods where working fine. I found out that endpoint called by frontend showed in screenshot in #2756 isgetGroupByIdmethod fromGroupController. I added filtering of series ids list inExerciseGroup. I also added integration test to check if filtering working properly for controller method.