Open
Conversation
Collaborator
|
他のチケットで対応したので、こちらは対応不要となりました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief
pypiへのcliboaパッケージのアップロードをトークンベースのロジックに修正
Points to Check
Test
Confirmed
ダミーのトークンでpypiへのアップロードが失敗するところまで確認済み
成功テストはトークンをupload_pypi.yamlにハードコードする必要があるため実施しない。mainにマージされた後、GitHubActionsから手動で実行予定
(Write content to confirm / Reason why not necessary)
Review Limit
Write review limit on pull request title.