[INFRA-6259] feat: implement reproducible zip#10
Merged
ajaxbits merged 6 commits intoBrandonLWhite:mainfrom May 1, 2025
Merged
[INFRA-6259] feat: implement reproducible zip#10ajaxbits merged 6 commits intoBrandonLWhite:mainfrom
ajaxbits merged 6 commits intoBrandonLWhite:mainfrom
Conversation
ajaxbits
changed the title
ajaxbits
force-pushed
the
INFRA-6259-impl-repro-zipfile
branch
from
d211495 to
8ad98bf
Compare
Owner
BrandonLWhite
left a comment
BrandonLWhite
left a comment
There was a problem hiding this comment.
See if you can simplify by using ZipFile.open()
Also, the nested-zip case needs to be handled too. It doesn't have to be in this PR if you prefer to get the basic case working first.
ajaxbits
changed the title
ajaxbits
force-pushed
the
INFRA-6259-impl-repro-zipfile
branch
from
1fce111 to
e5ae625
Compare
ajaxbits
commented
May 1, 2025
BrandonLWhite
approved these changes
May 1, 2025
Owner
BrandonLWhite
left a comment
BrandonLWhite
left a comment
There was a problem hiding this comment.
Just one issue in the test asserts then good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alters the zip method to reset all file permissions and timestamps of the files to be zipped, prior to zipping.
The file modification time respects
$SOURCE_DATE_EPOC(according to the reproducible builds spec), and defaults to 1/1/1980. The file permissions are also updated to644, to enforce standardization.More information on reproducible builds for zip files can be found here.