feat: implement nested zips#12
Merged
ajaxbits merged 10 commits intoBrandonLWhite:mainfrom May 2, 2025
Merged
Conversation
ajaxbits
force-pushed
the
INFRA-6259-implement-nested-zips
branch
from
3c1c11f to
12047f1
Compare
ajaxbits
force-pushed
the
INFRA-6259-implement-nested-zips
branch
from
4d7a913 to
22f701b
Compare
|
|
||
| class Packager: | ||
| AWS_LAMBDA_MAX_UNZIP_SIZE = 262144000 | ||
| AWS_LAMBDA_MAX_UNZIP_SIZE = 262_144_000 |
Owner
There was a problem hiding this comment.
Holy moly I didn't know you could do this. TIL about PEP-515. These days it is very rare for me to learn something new while reviewing a PR. Thanks!
BrandonLWhite
approved these changes
May 2, 2025
Owner
BrandonLWhite
left a comment
BrandonLWhite
left a comment
There was a problem hiding this comment.
Wow, nicely done!
Since you have done all of this thorough work and considered the many details, you should update the README to explain the behavior and the SOURCE_DATE_EPOCH env-var config.
Collaborator
Author
|
Good callout -- I'll get on that. |
ajaxbits
force-pushed
the
INFRA-6259-implement-nested-zips
branch
from
bbc7744 to
076d0a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements reproducibility for nested zip files.
Additionally, we add tests for nested zip files.
Finally, the test harness is overhauled to make writing verification tests easier.