Conversation
ajaxbits
force-pushed
the
impl-strip-mode
branch
10 times, most recently
from
b3737a9 to
b167414
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new “strip mode” feature to strip specific files (e.g., .pyc, .pyo, RECORD, direct_url.json, pycache) to ensure reproducible builds. Key changes include updates to test fixtures to verify file exclusion, modifications to packager logic to filter out unwanted files during zipping, and enhancements to documentation and coverage configuration.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_package_python_function.py | Added conditions to assert file exclusion based on test data. |
| tests/conftest.py | Revised test fixtures to include files_excluded_from_bundle handling. |
| pyproject.toml | Added coverage configuration to omit test files. |
| package_python_function/packager.py | Introduced constants and logic to exclude specific directories, files, and extensions. |
| README.md | Updated reproducibility notes and file exclusion documentation. |
BrandonLWhite
approved these changes
May 8, 2025
Owner
BrandonLWhite
left a comment
BrandonLWhite
left a comment
There was a problem hiding this comment.
See what you think about my nit comment. Otherwise good to go!
dihuynh
approved these changes
May 8, 2025
Strips all `.py{c,o}`, `RECORD`, `direct_url.json`, and `__pycache__`
files to ensure reproducible builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strips all
.py{c,o},RECORD,direct_url.json, and__pycache__files to ensure reproducible builds.