Allow node-mongod to start/stop forked mongod process#2
Allow node-mongod to start/stop forked mongod process#2CaleCrawford wants to merge 6 commits intoBrandonZacharie:developfrom
Conversation
|
I will fix the linting errors. |
|
For running the tests locally I am getting: (edit) - Locally that file is being created |
|
It likely means an instance of MongoDB is already running. Test failures may leave orphaned MongoDB processes running in the background. Edit: |
|
Thank you for the input, sorry it has been a bit of time in between my responses. Okay I wrote a few tests to test various aspects of the method. I am having trouble testing the reject() statements that run if ps-node throws an error. From my latest commit those are The travis-ci build had a timeout error for: node 4.8.4, node ~5, and node 6.0. The others passed. I tried running the tests locally using v4.8.4 and it passed. Any ideas why that would be working locally but failing on the ci build? Thank you again for taking the time to work through this with me. Im pretty new to open source so I appreciate your input. |
|
Good work getting this far. I suspect that the first timeout causes cascading test failures. I'll look at what you've got and revisit the Travis configuration this weekend. |
forked: truethe process is started in forked mode and the output is used to return success.ps-nodeis used to look for the forked process and then kill it.To the best of my knowledge none of this interferes with the currently implemented functionality. I would be happy to comment/document anything further that you think needs it. I also have a similar fix for the redis version.
Closes #1