fix: address PR #13 review comments on CI/CD workflow #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split shared PRIVATE_KEY/RPC_URL into separate TESTNET/MAINNET secrets to allow simultaneous testnet and mainnet deployments - Add foundry.toml validation to detect and fail early if [etherscan] sections reference undefined ETHERSCAN_API_KEY environment variable - Update README to document new separate testnet/mainnet secrets - Network config file already has correct mainnet/testnet values (Ethereum vs Sepolia)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all three unanswered comments from the PR #13 review:
Separate testnet/mainnet secrets: Split shared
PRIVATE_KEY/RPC_URLintoTESTNET_PRIVATE_KEY/TESTNET_RPC_URLandMAINNET_PRIVATE_KEY/MAINNET_RPC_URLto enable simultaneous deployments to different networks.Correct mainnet network config: Network configuration already uses correct values (
eth.blockscout.comfor mainnet,eth-sepolia.blockscout.comfor testnet).Detect etherscan config issues: Added foundry.toml validation that detects and fails early with helpful message if
[etherscan]section references${ETHERSCAN_API_KEY}(which isn't available in this workflow).Test plan
[etherscan]section