Open
Conversation
Co-authored-by: Brendonovich <Brendonovich@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is complete. Here's what was changed:
Graph.tsx: Added imports for
handleSelectableItemPointerDownandSelectedItemID, then modified the touch handling code to detect when a touch is on a node/commentbox header and call the appropriate handler.Node.tsx: Added
data-node-idattribute to the node container element.CommentBox.tsx: Added
data-commentbox-idattribute to the comment box container element.The fix works by checking if a touch event on a node/commentbox header (identified by specific button class patterns) should trigger node movement logic instead of drag selection. When detected, it calls
handleSelectableItemPointerDownwhich sets up ephemeral position updates, triggering the pin position recalculations that update connections.Closes #579
opencode session | github run