Open
Conversation
When comcut is part of a larger process, inconsistently creating an output file can cause quite the headache. When exiting with 73, (i.e. EX_CANTCREAT -- A (user specified) output file cannot be created.) subsequent scripts can use that info to prevent trying to work on a non-existent file.
Owner
|
I like the idea of this. In fact I wanted to have useful error codes when first developing this. What comes to mind is preserving error codes caused by comskip/ffmpeg/etc and return them with a prefix which would be indicative of what part of the process failed. For example if Comskip returned error code 46, comcut would return 10046. This is all off the top of my head, there may be a better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comcut is part of a larger process, inconsistently creating an output file can cause quite the headache. When exiting with 73, (i.e. EX_CANTCREAT -- A (user specified) output file cannot be created.) subsequent scripts can use that info to prevent trying to work on a non-existent file.
idk this may be a very wrong way to approach my problem—I don't write a lot of pure bash. But I definitely had one of those feelings like "I can't be the only one with this issue" when I was dealing with it so here we are.