Merged
Conversation
brewNoteWidget.ui to resolve bug Brewtarget#54
Contributor
|
Thanks Kapinga, looks good to me. I'll look for resolution on #54 before merging. |
malavv
approved these changes
Jul 6, 2017
Contributor
malavv
left a comment
malavv
left a comment
There was a problem hiding this comment.
Looking at the changes, I was initially worried that some background processing was using the old meaning but after looking, I could not find anything of the sort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug #54 started with an inconsistency on some tooltip labels between the brewnote ui and the help manual. This PR (along with one in the manual repo) resolves that inconsistency. I suggest that additional fields and UI changes (as mooted in #54) can be added in future releases with the appropriate DB schema.
I need someone to confirm I've used sane tooltips for Strike Temp and Final Temp.