Fix V1 legacy build: build via solution file and add workflow_dispatch ref input#49
Open
Fix V1 legacy build: build via solution file and add workflow_dispatch ref input#49
Conversation
Co-authored-by: BrianHumlicek <25691456+BrianHumlicek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix artifacts issue in legacy branch build process
Fix V1 legacy build: build via solution file and add workflow_dispatch ref input
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The V1 legacy build workflow was failing with
Error NU5019: File not found: 'bin\Release\J2534-Sharp.dll'because building via the.csprojdirectly leaves$(SolutionDir)undefined — causing MSBuild to write output to the drive root (D:\bin\Release\) instead of<repo_root>\bin\Release\. The previous-BasePath Srcfix was also incorrect for the same reason.Changes
nuget restoreandmsbuildnow targetJ2534-Sharp.slninstead ofsrc\J2534-Sharp.csproj, so$(SolutionDir)is set correctly and output lands in<repo_root>\bin\Release\as the nuspec expects-BasePath Src: no longer needed;bin\$configuration$\J2534-Sharp.dllin the nuspec resolves correctly from the repo rootworkflow_dispatchref input: adds an optionalrefinput (default:V1-legacy) so the workflow can be dispatched frommasterto build the legacy branch using the fixed workflow file — working around the still-broken workflow on theV1-legacybranch itselfinputs.reffor manual dispatch,github.reffor tag-triggered runspush: branches: [V1-legacy]onmasteris a no-op — GitHub evaluates push triggers from the pushed branch's own workflow files, notmaster's💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.