GAUD-9415 - Add more info and examples for using selection inputs in table#6545
Open
GAUD-9415 - Add more info and examples for using selection inputs in table#6545
Conversation
svanherk
changed the title
dlockhart
approved these changes
Feb 2, 2026
components/table/README.md
Outdated
| </d2l-table-wrapper> | ||
| ``` | ||
|
|
||
| If your table uses single selection, you should add an `aria-label` to the header instead (or use `offscreen` text). |
Member
There was a problem hiding this comment.
I wouldn't even mention offscreen text -- I think we always prefer aria-label.
Contributor
Author
|
FYI @geurts |
dlockhart
approved these changes
Feb 3, 2026
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
geurts
reviewed
Feb 3, 2026
components/table/README.md
Outdated
| </tr> | ||
| ``` | ||
|
|
||
| The `d2l-table-wrapper` is a [selection control component](../../components/selection/#selectionmixin), meaning you can use `d2l-input-select` components inside the table alongside a `d2l-selection-select-all` component in the header. |
Contributor
There was a problem hiding this comment.
I guess that should be d2l-selection-input?
dlockhart
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks super long, but it looks a lot better on the Daylight site. The code is hidden, so just the
htmlpieces are shown.I don't think there's an easy way for me to get a Daylight site preview before merging for reviewers -
documentationneeds a published version ofcorethat includes the demo components to build. 🤔