GAUD-9420: attempt to fix flaky collapsible panel test#6561
Open
GAUD-9420: attempt to fix flaky collapsible panel test#6561
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test flaked in Firefox in a CI run so I looked into it a bit.
The behaviour and test was introduced here and it's meant to keep the focus styles if the user clicks on the
<button>that surrounds the panel text.But the test isn't clicking on that button, it's clicking on the panel header. I've outlined the panel header in red and the button in blue:
The way that vdiff
clickElemworks is it gets the midpoint of the element and clicks there. So most of the time but depending on the viewport/font size clicking in the middle of the red outlined header should also result in clicking on the button and the test would pass. But possibly occasionally it misses the button and just clicks on the header, which would remove the focus styles and fail the test.That's my theory anyway!