Update backdrop to support table loading state#6570
Draft
duncanuszkay-d2l wants to merge 1 commit intomainfrom
Draft
Update backdrop to support table loading state#6570duncanuszkay-d2l wants to merge 1 commit intomainfrom
duncanuszkay-d2l wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
0e7c051 to
0d1ae75
Compare
duncanuszkay-d2l
commented
Feb 6, 2026
Comment on lines
+207
to
+209
| if (options.contained && isPositionedElement(parent)) { | ||
| break; | ||
| } |
Author
There was a problem hiding this comment.
One possible alternative is to either disable the aria-hiding stage entirely when the contained option is set, or possibly add another option to disable aria-hiding, but I felt that this option to hide within the container was the most intuitive for the downstream consumer.
0d1ae75 to
1fe84f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream ticket
Upstream ticket
We want to add a visual loading state to the table in the event that the data needs to be refreshed. This can occur after filters are applied, sort orders are changed, and possibly in future when we move to a new page.
In this PR, I'm updating the existing backdrop component in a few ways to make it compatible with this solution:
containedoption which limits the backdrop to the containing block instead of attaching it to the viewportcontained, it doesn't prevent body scrollingVideo Demo
Recording.2026-02-06.134345.mp4