Merge/wl581 onchain config

[ZouBadCode]

---

Testing Workflow Improvements

• Added segmented test commands (test:unit, test:e2e, test:coverage, etc.) in package.json and documented their usage in CLAUDE.md to allow running unit and e2e tests separately and improve coverage reporting.
• Added @vitest/coverage-v8 and related dependencies to support coverage reporting, reflected in both package.json and pnpm-lock.yaml.
• Clarified test strategy in CLAUDE.md, distinguishing between fast local unit tests and e2e tests that interact with mainnet RPC, with guidance on avoiding RPC rate limits.

---

On-Chain Config Integration & SDK Caching

Added configAdaptor.ts

• Introduced configAdaptor.ts to adapt on-chain config objects into the SDK’s internal config structure.
• The adaptor populates and maintains an in-memory cache inside the SDK to reduce redundant RPC calls.
• Ensures SDK consumers always interact with normalized, ready-to-use config data.

Added bucketConfig.ts

• Added bucketConfig.ts as a dedicated module responsible for fetching on-chain config data.
• Encapsulates chain query logic and provides a clean interface for retrieving the latest protocol configuration.

Automatic Config Validation & Refetch

• Before executing SDK methods, the client now automatically validates the required config.
• If any required config segment is missing or invalid, the SDK will automatically refetch the latest config from chain.
• This improves reliability and reduces the risk of misconfigured client usage.

---

Documentation Updates

• Updated README.md and CLAUDE.md to standardize initialization via:

  const client = await BucketClient.initialize(...)

• Documented that BucketClient.initialize():

  • Fetches config from chain
  • Normalizes it through the adaptor
  • Populates the internal SDK cache
  • Ensures the client is fully ready before use

• Clarified best practices for client initialization and config lifecycle management.

---

Dependency Management

• Updated pnpm-lock.yaml with new packages required for coverage and testing, including:

  • @vitest/coverage-v8
  • Istanbul libraries
  • Related coverage utilities

---

[bucket-bot]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Noted: this is a large refactor (+2768/-1342), but the async initialization flow, on-chain config adapter, and new e2e/unit coverage are consistent.

🤖 Generated with Rex (OpenClaw)

[bucket-bot]

Code review

Found 2 issues:

1. queryAllConfig can return a partial config after RPC/object parse errors, and initialization still succeeds. This creates a fail-open path where required package IDs/object refs become empty strings/default refs and later transaction builders produce malformed targets/refs instead of failing at init time. Please fail fast by validating required sections/keys (e.g. packageConfig/oracleConfig/objectConfig + required fields) and throw when any mandatory object in id_vector cannot be resolved.

bucket-protocol-sdk/src/utils/bucketConfig.ts

Lines 136 to 176 in 57e9475

	if (obj instanceof Error) {
	console.error('Failed to fetch object:', obj.message);
	continue;
	}
	const type = obj.type;
	const json = obj.json as Record<string, unknown> | null;
	if (!json) continue;
	try {
	if (type.endsWith(TYPE_PACKAGE_CONFIG)) {
	result.packageConfig = json;
	} else if (type.endsWith(TYPE_ORACLE_CONFIG)) {
	result.oracleConfig = json;
	} else if (type.endsWith(TYPE_OBJECT_CONFIG)) {
	result.objectConfig = json;
	} else if (type.endsWith(TYPE_AGGREGATOR)) {
	const entries = parseVecMap(json.table);
	result.aggregator = { id: json.id as string, entries };
	} else if (type.endsWith(TYPE_VAULT)) {
	const entries = parseVecMap(json.table);
	result.vault = { id: json.id as string, entries };
	} else if (type.endsWith(TYPE_SAVING_POOL)) {
	const entries = parseVecMap(json.table);
	result.savingPool = { id: json.id as string, entries };
	} else if (type.endsWith(TYPE_PSM_POOL)) {
	const entries = parseVecMap(json.table);
	result.psmPool = { id: json.id as string, entries };
	} else if (type.endsWith(TYPE_PRICE_CONFIG)) {
	const entries = parseVecMap(json.table);
	result.priceConfig = { id: json.id as string, entries };
	} else {
	// eslint-disable-next-line no-console
	console.warn(`Unknown object type: ${type} (objectId: ${obj.objectId})`);
	}
	} catch (e) {
	console.error(`Failed to process object ${obj.objectId} (type: ${type}):`, e);
	}
	}
	return result;

2. initialize({ configOverrides }) stores overrides on the instance, but refreshConfig() does not preserve them when called without args. A later refresh silently drops prior overrides (e.g. custom PRICE_SERVICE_ENDPOINT) and changes runtime behavior unexpectedly. Consider defaulting to overrides ?? this.configOverrides and updating this.configOverrides when explicit overrides are provided.

bucket-protocol-sdk/src/client.ts

Lines 114 to 164 in 57e9475

	bc.configOverrides = configOverrides;
	return bc;
	}
	/**
	* @description Ensures config is loaded. If not yet fetched, fetches from on-chain.
	*/
	private async ensureConfig(): Promise<void> {
	if (!this._config) {
	await this.refreshConfig(this.configOverrides);
	}
	}
	/**
	* @description Returns the current config, throwing if not yet initialized.
	* For sync methods that cannot await ensureConfig().
	*/
	private get config(): ConfigType {
	if (!this._config) {
	throw new Error(
	'BucketClient config not initialized. ' +
	'Call an async method first, use BucketClient.initialize(), or pass config to the constructor.',
	);
	}
	return this._config;
	}
	/* ----- Getter ----- */
	/**
	* @description Get this.suiClient
	*/
	getSuiClient(): SuiGrpcClient {
	return this.suiClient;
	}
	/**
	* @description
	*/
	async getConfig(): Promise<ConfigType | undefined> {
	await this.ensureConfig();
	return this.config;
	}
	/**
	* @description Re-fetch config from on-chain and update this client's config.
	*/
	async refreshConfig(overrides?: Partial<ConfigType>): Promise<void> {
	const onchainConfig = await queryAllConfig(this.suiClient, this.network);
	this._config = convertOnchainConfig(onchainConfig, overrides);
	}

🤖 Generated with Rex (OpenClaw)

[bucket-bot]

Code Review

Found 4 issues worth addressing:

---

1. initialSharedVersion: 0 fallback in toSharedObjectRef will break transactions (confidence: 88)

When json is a plain string (objectId only), the function defaults to initialSharedVersion: 0. Sui requires the correct initial shared version for shared object references in PTBs — using 0 here will silently produce invalid transactions at runtime. If only an objectId string arrives from on-chain JSON, the code should either throw or fetch the actual version separately.

bucket-protocol-sdk/src/utils/configAdapter.ts

Lines 19 to 24 in 57e9475

	return { objectId: json, initialSharedVersion: 0, mutable };
	}
	const obj = json as Record<string, unknown>;
	return {
	objectId: (obj.id ?? obj.objectId ?? '') as string,
	initialSharedVersion: (obj.initial_shared_version ?? obj.initialSharedVersion ?? 0) as number | string,

---

2. Race condition in ensureConfig — parallel calls before config loads will trigger multiple RPC fetches (confidence: 82)

private async ensureConfig(): Promise<void> {
  if (!this._config) {
    await this.refreshConfig(this.configOverrides); // no in-flight guard
  }
}

If two async SDK methods are called concurrently before config is initialized (e.g. client.getOraclePrices() and client.getVaultObjectInfo() in parallel), both see _config === null and trigger separate queryAllConfig RPC calls. Fix with a cached promise:

private _configPromise: Promise<void> | null = null;

private async ensureConfig(): Promise<void> {
  if (!this._config) {
    this._configPromise ??= this.refreshConfig(this.configOverrides).finally(() => {
      this._configPromise = null;
    });
    await this._configPromise;
  }
}

bucket-protocol-sdk/src/client.ts

Lines 95 to 99 in 57e9475

	* @description Factory that creates a BucketClient with config fetched from on-chain.
	* Use this when you want the SDK to always use the latest on-chain parameters.
	*
	* @param options.configOverrides - Optional overrides (e.g. PRICE_SERVICE_ENDPOINT).
	*/

---

3. refreshConfig() called without args silently drops configOverrides (confidence: 82)

initialize() stores configOverrides on the instance, and ensureConfig() correctly passes them through. But refreshConfig() is a public method — if a consumer calls client.refreshConfig() directly (without overrides), the stored overrides are lost and the config reverts to pure on-chain values. Consider making refreshConfig always apply the stored this.configOverrides as defaults:

async refreshConfig(overrides?: Partial<ConfigType>): Promise<void> {
  const onchainConfig = await queryAllConfig(this.suiClient, this.network);
  this._config = convertOnchainConfig(onchainConfig, overrides ?? this.configOverrides);
}

bucket-protocol-sdk/src/client.ts

Lines 102 to 105 in 57e9475

	network = 'mainnet',
	configOverrides,
	}: {
	suiClient?: SuiGrpcClient;

---

4. Previously synchronous public getters are now async — breaking API change without semver bump (confidence: 85)

getUsdbCoinType(), getAllOracleCoinTypes(), getAllCollateralTypes(), getAggregatorObjectInfo(), getVaultObjectInfo(), getSavingPoolObjectInfo(), getPsmPoolObjectInfo() were all synchronous before. They now return Promise<T>. Any existing consumer using the return value directly (e.g. const t = client.getUsdbCoinType()) now gets a Promise<string> instead of a string — a silent runtime break unless TypeScript is strict. This PR should either bump the major version or provide deprecation shims. At minimum, the PR description and CHANGELOG should call this out explicitly as a breaking change.

bucket-protocol-sdk/src/client.ts

Lines 156 to 165 in 57e9475

	}
	/**
	* @description Re-fetch config from on-chain and update this client's config.
	*/
	async refreshConfig(overrides?: Partial<ConfigType>): Promise<void> {
	const onchainConfig = await queryAllConfig(this.suiClient, this.network);
	this._config = convertOnchainConfig(onchainConfig, overrides);
	}

---

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Re-review (on-chain config request path)

這版修正方向很對（fail-fast on fetch/parse、ensureConfig race、refresh override 保留、shared version enrichment 都補上了 👍）。

我再看 queryAllConfig 的請求邏輯後，還有一個高風險邊界：

1. 目前仍未驗證「必要 config section 是否齊全」

queryAllConfig 結尾直接 return result，但沒有檢查 packageConfig / oracleConfig / objectConfig 是否都存在。若 RPC 回傳不完整（例如 id_vector 少項、未知 type 被 warn 後略過、或服務端只回部分 objects），流程仍會成功返回，後續 convertOnchainConfig 會用空字串/預設值填充，變成延遲失敗。

建議在返回前加 required-section validation（至少三個核心 section + 可選地驗證關鍵欄位非空），缺任一個就 throw，讓初始化在入口就 fail-fast。

參考位置：

bucket-protocol-sdk/src/utils/bucketConfig.ts

Lines 146 to 178 in 71d7db9

	try {
	if (type.endsWith(TYPE_PACKAGE_CONFIG)) {
	result.packageConfig = json;
	} else if (type.endsWith(TYPE_ORACLE_CONFIG)) {
	result.oracleConfig = json;
	} else if (type.endsWith(TYPE_OBJECT_CONFIG)) {
	result.objectConfig = json;
	} else if (type.endsWith(TYPE_AGGREGATOR)) {
	const entries = parseVecMap(json.table);
	result.aggregator = { id: json.id as string, entries };
	} else if (type.endsWith(TYPE_VAULT)) {
	const entries = parseVecMap(json.table);
	result.vault = { id: json.id as string, entries };
	} else if (type.endsWith(TYPE_SAVING_POOL)) {
	const entries = parseVecMap(json.table);
	result.savingPool = { id: json.id as string, entries };
	} else if (type.endsWith(TYPE_PSM_POOL)) {
	const entries = parseVecMap(json.table);
	result.psmPool = { id: json.id as string, entries };
	} else if (type.endsWith(TYPE_PRICE_CONFIG)) {
	const entries = parseVecMap(json.table);
	result.priceConfig = { id: json.id as string, entries };
	} else {
	// eslint-disable-next-line no-console
	console.warn(`Unknown object type: ${type} (objectId: ${obj.objectId})`);
	}
	} catch (e) {
	const msg = e instanceof Error ? e.message : String(e);
	throw new Error(`Failed to process config sub-object ${obj.objectId} (type: ${type}): ${msg}`);
	}
	}
	return result;

🤖 Generated with Rex (OpenClaw)

[bucket-bot]

Code Review (Round 2)

四個問題都有對應處理，整體方向正確。剩下一個需要留意：

---

✅ 已修 — queryAllConfig fail-fast
continue 改成 throw，partial config 問題解決。對應測試也更新了，Good。

✅ 已修 — refreshConfig 保留 overrides
overrides ?? this.configOverrides ✓

✅ 已修 — enrichSharedObjectRefs 補 initialSharedVersion
深克隆 + batch fetch + 正確 apply，邏輯清楚。

---

⚠️ 仍有問題 — _configInitPromise 失敗後無法重試 (confidence: 82)

private async ensureConfig(): Promise<void> {
  if (this._config) return;
  if (!this._configInitPromise) {
    this._configInitPromise = this.refreshConfig(this.configOverrides);
  }
  await this._configInitPromise; // ← 若 reject，下次仍 await 同一個 rejected promise
}

_configInitPromise 失敗後永遠不會被清除。只要 refreshConfig 因為網路閃斷 throw 一次，this._config 仍是 null、this._configInitPromise 是 rejected promise，後續所有 ensureConfig 呼叫都會吃到那個舊的 rejection，client 永久不可用，無法重試。建議在 finally 清除：

private async ensureConfig(): Promise<void> {
  if (this._config) return;
  if (!this._configInitPromise) {
    this._configInitPromise = this.refreshConfig(this.configOverrides)
      .finally(() => { this._configInitPromise = null; });
  }
  await this._configInitPromise;
}

bucket-protocol-sdk/src/client.ts

Lines 119 to 126 in 71d7db9

	/**
	* @description Ensures config is loaded. If not yet fetched, fetches from on-chain.
	* Uses cached promise to avoid race when multiple async methods call concurrently.
	*/
	private async ensureConfig(): Promise<void> {
	if (this._config) return;
	if (!this._configInitPromise) {

---

其他部分 LGTM，測試覆蓋也到位。

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Re-review (latest push)

queryAllConfig 這次補的 required-section / required-field validation 看起來 OK，方向正確 👍

目前還有一個 blocker 仍在：

1. _configInitPromise 在初始化失敗後沒有 reset

ensureConfig() 會快取 this._configInitPromise，但若第一次 refreshConfig() reject（例如暫時性 RPC/network error），這個 rejected promise 會一直留著。之後所有 ensureConfig() 都會直接 await 同一個 rejected promise，client 無法自動重試，等於永久卡死。

建議在設置 promise 時加 finally 清理：

if (!this._configInitPromise) {
  this._configInitPromise = this.refreshConfig(this.configOverrides)
    .finally(() => {
      this._configInitPromise = null;
    });
}
await this._configInitPromise;

參考位置：

bucket-protocol-sdk/src/client.ts

Lines 124 to 130 in 10e7218

	private async ensureConfig(): Promise<void> {
	if (this._config) return;
	if (!this._configInitPromise) {
	this._configInitPromise = this.refreshConfig(this.configOverrides);
	}
	await this._configInitPromise;
	}

🤖 Generated with Rex (OpenClaw)

[bucket-bot]

Code Review (Round 3)

Required-section 驗證加了，邏輯清楚，測試覆蓋也很完整。

但上一輪指出的 _configInitPromise 問題還沒修到：

---

⚠️ _configInitPromise 失敗後未清除，client 無法從網路錯誤中恢復 (confidence: 82)

// src/client.ts — 目前狀態
private async ensureConfig(): Promise<void> {
  if (this._config) return;
  if (!this._configInitPromise) {
    this._configInitPromise = this.refreshConfig(this.configOverrides);
    // ← 沒有 finally 清除
  }
  await this._configInitPromise;
}

refreshConfig 因網路閃斷 reject 一次後，_configInitPromise 永遠保留那個 rejected promise，後續所有 ensureConfig 呼叫都重新 await 同一個已失敗的 promise，client 永久不可用。Fix 一行：

this._configInitPromise = this.refreshConfig(this.configOverrides)
  .finally(() => { this._configInitPromise = null; });

bucket-protocol-sdk/src/client.ts

Lines 119 to 126 in 10e7218

	/**
	* @description Ensures config is loaded. If not yet fetched, fetches from on-chain.
	* Uses cached promise to avoid race when multiple async methods call concurrently.
	*/
	private async ensureConfig(): Promise<void> {
	if (this._config) return;
	if (!this._configInitPromise) {

---

其他部分（required-section 驗證、測試覆蓋）全部 LGTM，修完這個就可以 approve 了。

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Re-review

Latest commit resolves the remaining blocker.

• ensureConfig() now clears _configInitPromise on failure, so transient init errors no longer permanently poison the client.
• Added retry-focused unit coverage (clears _configInitPromise on failure so subsequent calls can retry).
• Previously discussed on-chain config request-path fixes (fail-fast sub-object handling + required section validation) are still in place.

LGTM. Approving.

🤖 Generated with Rex (OpenClaw)

[bucket-bot]

所有問題都解決了：

• ✅ queryAllConfig fail-fast（不再回傳 partial config）
• ✅ required-section 驗證
• ✅ refreshConfig 保留 configOverrides
• ✅ ensureConfig race condition
• ✅ initialSharedVersion enrichment
• ✅ _configInitPromise 失敗後清除，允許重試

LGTM 🚀

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Re-review (BucketClient initialization changes)

Found 1 issue:

1. initialize({ configObjectId }) and refreshConfig() now have inconsistent config source behavior. Initial load can come from a custom entry object, but refreshConfig() always calls queryAllConfig(this.suiClient, this.network) and drops that custom source. After first refresh, the client may silently switch back to default network config, which is risky for test/custom deployments. Please persist configObjectId on the instance and reuse it in refreshConfig().

bucket-protocol-sdk/src/client.ts

Lines 104 to 160 in 517121e

	static async initialize({
	suiClient,
	network = 'mainnet',
	configObjectId,
	config: configParam,
	configOverrides,
	}: {
	suiClient?: SuiGrpcClient;
	network?: Network;
	configObjectId?: string;
	config?: ConfigType;
	configOverrides?: Partial<ConfigType>;
	} = {}): Promise<BucketClient> {
	const rpcUrl = NETWORK_RPC_URLS[network] ?? NETWORK_RPC_URLS['mainnet']!;
	const client = suiClient ?? new SuiGrpcClient({ network, baseUrl: rpcUrl });
	let config: ConfigType;
	if (configParam) {
	config = await enrichSharedObjectRefs(configParam, client);
	} else {
	const onchainConfig = await queryAllConfig(client, network, configObjectId);
	config = convertOnchainConfig(onchainConfig, configOverrides);
	config = await enrichSharedObjectRefs(config, client);
	}
	const bc = new BucketClient({ suiClient: client, network, config });
	bc.configOverrides = configOverrides;
	return bc;
	}
	private get config(): ConfigType {
	return this._config;
	}
	/* ----- Getter ----- */
	/**
	* @description Get this.suiClient
	*/
	getSuiClient(): SuiGrpcClient {
	return this.suiClient;
	}
	/**
	* @description
	*/
	getConfig(): ConfigType {
	return this.config;
	}
	/**
	* @description Re-fetch config from on-chain and update this client's config.
	* When overrides is omitted, preserves configOverrides from initialize().
	*/
	async refreshConfig(overrides?: Partial<ConfigType>): Promise<void> {
	const onchainConfig = await queryAllConfig(this.suiClient, this.network);
	let config = convertOnchainConfig(onchainConfig, overrides ?? this.configOverrides);

🤖 Generated with Rex (OpenClaw)

[bucket-bot]

Code Review (Round 5 — 初始化重構)

這次改法方向完全正確，大幅簡化了複雜度。

---

✅ 設計改進

• Constructor 改成 config 必填 → 徹底消除 lazy init 邏輯（ensureConfig、_configInitPromise 全刪）
• Getter 全部回到 sync (getConfig(), getUsdbCoinType() 等) → 解決之前的 breaking API change 問題
• initialize() 加了 configObjectId 和 config 注入點 → 方便測試，不用打真實 RPC
• queryAllConfig 多一個 optional configObjectId 參數 → 設計一致

整體 LGTM 🚀

---

⚠️ 一個小地方值得留意（non-blocking）

initialize() 的 configParam 路徑沒有套用 configOverrides：

if (configParam) {
  config = await enrichSharedObjectRefs(configParam, client);
  // ← configOverrides 這裡沒有 apply，但 bc.configOverrides 還是設了
} else {
  config = convertOnchainConfig(onchainConfig, configOverrides); // ← 這裡有套用
  config = await enrichSharedObjectRefs(config, client);
}
const bc = new BucketClient({ suiClient: client, network, config });
bc.configOverrides = configOverrides;

結果：傳 config + configOverrides 給 initialize() 時，初始 config 不含 overrides，但之後呼叫 refreshConfig() 會套用。行為有點不一致。
這個路徑主要給測試用，影響面小；但如果這是 intentional，建議在 JSDoc 補一句說明，避免誤用。

---

Non-blocking，可 merge。

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

✅ configObjectId 正確存在 instance、refreshConfig() 也傳進去了，行為一致。JSDoc 也補清楚了（包含 config + configOverrides 的行為說明）。測試直接驗 queryAllConfig 被呼叫時帶了正確的 configObjectId，覆蓋到位。

LGTM，可以 merge 🚀

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Re-review

Latest commit addresses the remaining initialization-path concern.

• BucketClient now persists configObjectId from initialize().
• refreshConfig() reuses that same configObjectId, so config source no longer silently switches back to default entry config.
• Unit coverage was added for this exact behavior (refreshConfig() uses configObjectId from initialize).
• JSDoc clarifications around config + configOverrides behavior are also helpful.

LGTM. Approving.

🤖 Generated with Rex (OpenClaw)

[do0x0ob]

---

PR 變更摘要

核心變更

1. On-chain config

   • 從鏈上取得 config，不再使用靜態 CONFIG[network]
   • 新增 bucketConfig.ts、configAdapter.ts 負責查詢與轉換

2. BucketClient 初始化

   • 建構子改為必須傳入 config
   • 新增 BucketClient.initialize() 作為唯一從鏈上取得 config 的入口
   • 支援 configObjectId、config、configOverrides 參數

3. API 調整

   • getConfig() 改為 sync（config 在建構時已存在）
   • 多個 getter 改為 sync（如 getUsdbCoinType、getAllCollateralTypes 等）
   • 新增 refreshConfig() 用於重新從鏈上取得 config
   • savingPoolWithdraw 改為 sync，與 main 一致

4. PR review 修正

   • refreshConfig() 會沿用 initialize() 的 configObjectId
   • 補充 JSDoc 說明 config + configOverrides 的行為

其他

• 測試：E2E 與 unit 測試配合新 API 調整
• README：更新 Quick Start 與 API 說明
• .gitignore：加入 .pnpm-store

---

[bucket-bot]

Code Review — 移除包裝層重構

✅ LGTM

• private _config + getter 合併成直接的 private config field，更簡潔
• 所有 _method() private 包裝全部移除，邏輯直接 inline 到 public method — 沒有漏掉任何調用點
• 內部互呼（aggregatePrices、getAccountPositions 等）已全部更新為直接呼叫 public 方法，行為一致
• README flashBurn 參數修正（flashMintReceipt）也是正確的

無新問題引入，可以 merge 🚀

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Code review

Found 1 issue:

1. Silent failure in enrichSharedObjectRefs — when getObjects returns an Error for any object, the error is silently skipped with continue. The ref keeps initialSharedVersion: 0, which will cause PTB rejection at transaction time with no useful error message pointing back to the version enrichment step.

bucket-protocol-sdk/src/utils/configAdapter.ts

Lines 304 to 310 in f94f48c

	collect(config.SAVING_POOL_INCENTIVE_GLOBAL_CONFIG_OBJ);
	collect(config.FLASH_GLOBAL_CONFIG_OBJ);
	collect(config.BLACKLIST_OBJ);
	for (const priceInfo of Object.values(config.PRICE_OBJS)) {
	switch (priceInfo.variant) {
	case 'SCOIN':
	collect(priceInfo.scoinRuleConfig);

Consider throwing (or at least logging a warning) when an object lookup fails during enrichment:

if (obj instanceof Error) {
  console.warn(`enrichSharedObjectRefs: failed to fetch object for version enrichment: ${obj.message}`);
  continue;
}

This makes the failure surface immediately instead of silently building a broken config.

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Code review

Found 1 issue:

Silent error swallowing in enrichSharedObjectRefs — fetch failures leave refs with initialSharedVersion: 0

bucket-protocol-sdk/src/utils/configAdapter.ts

Lines 344 to 349 in f94f48c

	if (obj instanceof Error) continue;
	const owner = (obj as { owner?: { $kind?: string; Shared?: { initialSharedVersion?: string } } }).owner;
	if (owner?.$kind === 'Shared' && owner.Shared?.initialSharedVersion) {
	versionMap.set(obj.objectId, owner.Shared.initialSharedVersion);
	}
	}

When client.getObjects() returns an Error for one of the shared-object refs, the loop silently skips it and the ref stays at initialSharedVersion: 0. Sui validators will reject any PTB that references a shared object with initialSharedVersion: 0, producing a confusing low-level error at tx submission time instead of a clear SDK error at initialization.

Suggest either:

// Option A — throw fast (preferred)
if (obj instanceof Error) {
  throw new Error(`Failed to fetch shared object ${obj.objectId} for version enrichment: ${obj.message}`);
}

// Option B — warn and let callers discover the issue
if (obj instanceof Error) {
  console.warn(`enrichSharedObjectRefs: failed to fetch ${obj.objectId}, initialSharedVersion will be 0: ${obj.message}`);
  continue;
}

---

Everything else looks solid. The on-chain config migration is clean — queryAllConfig fail-fasts on required sections, the configOverrides merge order is correct, and the BucketClient.initialize() async factory pattern is a good API design. The Option<T> → bcs.option() and module 'object' casing fixes in _generated/utils/index.ts are correct bug fixes.

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Fix confirmed ✅

The loop was refactored to for (let i = 0; i < objects.length; i++) so objectIds[i] is accessible when logging. The console.warn now surfaces the objectId and error message, making any future enrichment failures debuggable. Reasonable choice to warn-and-continue rather than throw (lets the SDK still function for other refs).

No further issues found. LGTM.

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Code review (latest commit 24295a9)

Found 1 issue:

Missing case 'Unihouse' in getDerivativePrice switch → runtime throw for Unihouse derivatives

bucket-protocol-sdk/src/client.ts

Lines 1068 to 1088 in 24295a9

	? 'BFBTC'
	: derivative_kind === 'TLP'
	? 'TLP'
	: 'sCoin'; // fallback
	const priceConfig = this.getPriceConfigInfo(dk);
	switch (derivative_kind) {
	case 'sCoin':
	case 'Scallop': {
	if (!('SCOIN' in priceConfig) || !priceConfig.SCOIN)
	throw new Error('Unexpected price config variant for sCoin');
	const pc = priceConfig.SCOIN;
	tx.moveCall({
	target: `${pc.package}::scoin_rule::feed`,
	typeArguments: [coinType, underlying_coin_type],
	arguments: [
	collector,
	tx.sharedObjectRef(pc.scoin_rule_config),
	underlyingPriceResult,
	tx.sharedObjectRef(pc.scallop_version),
	tx.sharedObjectRef(pc.scallop_market),

The dk mapping explicitly includes 'Unihouse' → 'gCoin':

derivative_kind === 'GCoin' || derivative_kind === 'gCoin' || derivative_kind === 'Unihouse'
  ? 'gCoin'

But the switch (derivative_kind) below only has case 'gCoin': and case 'GCoin': — no case 'Unihouse':. So any coin with derivative_kind === 'Unihouse' will fall through to default: throw.

Fix:

case 'gCoin':
case 'GCoin':
case 'Unihouse': {   // ← add this
  ...
}

---

Everything else in this refactor looks correct. The type alignment with generated BCS types (SharedObjectRef[''], initialSharedVersion: string, snake_case field names, discriminated union shape for AggregatorObjectInfo / PriceConfigInfo) is clean and consistent throughout configAdapter.ts, client.ts, and tests.

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Fix confirmed ✅ — case 'Unihouse': added to the same block as gCoin/GCoin, consistent with the dk mapping. No further issues found. LGTM.

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Code review

Found 1 issue:

1. Wrong field name in test — config.PSM_OBJS should be config.PSM_POOL_OBJS (field was renamed in this PR but the test wasn't updated)

bucket-protocol-sdk/test/e2e/all-query-outputs.test.ts

Lines 131 to 133 in 7c47e14

	await run('getAllOracleCoinTypes', () => Promise.resolve(bucketClient.getAllOracleCoinTypes()));
	await run('getAllCollateralTypes', () => Promise.resolve(bucketClient.getAllCollateralTypes()));
	await run('getAggregatorObjectInfo', () =>

config.PSM_OBJS doesn't exist on ConfigType — the correct field is PSM_POOL_OBJS. The ?? {} fallback silently hides the typo, so firstPsmCoinType will always fall back to usdcCoinType instead of reading from actual config.

---

Everything else looks solid. The on-chain config migration is well-structured:

• Fail-fast validation in queryAllConfig ✅
• enrichSharedObjectRefs dedup + warn-on-error is reasonable ✅
• snake_case field rename (rewarder_id, reward_type, etc.) is consistent across client + types ✅
• get_realtime_reward_amount refactor for saving pool rewards (avoids PTB ref limitation) ✅
• getUsdbSupply switch from PTB simulation to stateService.getCoinInfo ✅
• Error handling upgraded from silent-empty to explicit throws ✅

🤖 Generated with Jarvis (OpenClaw)

[bucket-bot]

Code review

The fix looks good — PSM_OBJS → PSM_POOL_OBJS is corrected, and the new assertions (toBeGreaterThan(0) for PSM/saving/collateral pools) properly fail-fast instead of silently falling back. No further issues found.

🤖 Generated with Jarvis (OpenClaw)