Skip to content

Clean up macOS leftovers and inline title helpers#370

Merged
BugenZhao merged 5 commits intomainfrom
bz/adequate-leopon
Mar 14, 2026
Merged

Clean up macOS leftovers and inline title helpers#370
BugenZhao merged 5 commits intomainfrom
bz/adequate-leopon

Conversation

@BugenZhao
Copy link
Owner

Summary

  • remove unused macOS build leftovers and dead xargo configuration
  • delete unreferenced macOS app sources and flatten remaining iOS-only branches
  • inline navigation title and toolbar placement helpers into direct SwiftUI APIs

Verification

  • xcodebuild -project app/MNGA.xcodeproj -scheme MNGA -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 17,OS=26.2" build CODE_SIGNING_ALLOWED=NO
  • make swiftformat

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copilot AI review requested due to automatic review settings March 14, 2026 14:04
@BugenZhao BugenZhao enabled auto-merge (squash) March 14, 2026 14:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes macOS platform support (build targets, source files, conditional compilation branches) and inlines helper wrappers (navigationTitleInline, navigationTitleLarge, mayNavigationBarTrailing, etc.) into direct SwiftUI API calls.

Changes:

  • Delete all macOS-specific source files, entitlements, Info.plist, Xargo config, and commented-out Tuist target definition
  • Remove #if os(macOS) / #if os(iOS) conditional branches throughout shared code, flattening to iOS-only paths
  • Replace custom navigation title/toolbar placement helpers with direct SwiftUI APIs (.navigationTitle, .navigationBarTitleDisplayMode, .navigationBarTrailing)

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
logic/logic/Xargo.toml Remove dead xargo (Catalyst) config
app/macOS/* Delete all macOS source files
app/Project.swift Remove commented-out macOS target
app/Shared/Utilities/Platform.swift Remove macOS branches, inline title/toolbar helpers; move copyToPasteboard into View extension
app/Shared/Views/*.swift Replace helper calls with direct SwiftUI APIs
app/Shared/MNGAApp.swift Remove macOS Settings scene and flatten #if
Makefile Remove macOS/Catalyst build targets and cargo-lipo
README.md Update feature description and build instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
…tyle(.insetGrouped)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao merged commit 2eaa790 into main Mar 14, 2026
2 checks passed
@BugenZhao BugenZhao deleted the bz/adequate-leopon branch March 14, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants