Clean up macOS leftovers and inline title helpers#370
Merged
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes macOS platform support (build targets, source files, conditional compilation branches) and inlines helper wrappers (navigationTitleInline, navigationTitleLarge, mayNavigationBarTrailing, etc.) into direct SwiftUI API calls.
Changes:
- Delete all macOS-specific source files, entitlements, Info.plist, Xargo config, and commented-out Tuist target definition
- Remove
#if os(macOS)/#if os(iOS)conditional branches throughout shared code, flattening to iOS-only paths - Replace custom navigation title/toolbar placement helpers with direct SwiftUI APIs (
.navigationTitle,.navigationBarTitleDisplayMode,.navigationBarTrailing)
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| logic/logic/Xargo.toml | Remove dead xargo (Catalyst) config |
| app/macOS/* | Delete all macOS source files |
| app/Project.swift | Remove commented-out macOS target |
| app/Shared/Utilities/Platform.swift | Remove macOS branches, inline title/toolbar helpers; move copyToPasteboard into View extension |
| app/Shared/Views/*.swift | Replace helper calls with direct SwiftUI APIs |
| app/Shared/MNGAApp.swift | Remove macOS Settings scene and flatten #if |
| Makefile | Remove macOS/Catalyst build targets and cargo-lipo |
| README.md | Update feature description and build instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tyle(.insetGrouped) Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification