Add locate-floor action for author-only topics#372
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Swift-side mechanism to “locate” an author-only reply’s corresponding floor in the full topic, enabling navigation back to the originating topic and scrolling/loading the correct page when needed.
Changes:
- Introduces
TopicPostLocatorto cache post locations and scan topic pages on demand to resolve a post’s full-topic floor/page. - Wires a
Locate This Flooraction through topic details, author-only topic navigation, and reply-chain navigation. - Seeds locator state from loaded full-topic replies (while keeping author-only floor display unchanged).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/Shared/Views/TopicDetailsView.swift | Adds locator state + callback plumbing; seeds locator from topic responses; adds locate/jump helpers and navigation wiring. |
| app/Shared/Views/PostReplyChainView.swift | Passes locate callback through author-only navigation destination. |
| app/Shared/Models/TopicPostLocator.swift | New model to cache/scan full-topic pages to resolve a post’s page/floor location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopicPostLocatorthat caches full-topic post locations and scans full-topic pages on demand when author-only needs to resolve a post back to its real floorLocate This Floorthrough topic details and reply-chain navigation so author-only can dismiss back to the originating topic and jump to the matching full-topic postTesting
make swiftformatmake buildmnga://topic/45315204This Author OnlyLocate This Floor