Skip to content

Add locate-floor action for author-only topics#372

Merged
BugenZhao merged 3 commits intomainfrom
bz/author-only-locate-floor
Mar 15, 2026
Merged

Add locate-floor action for author-only topics#372
BugenZhao merged 3 commits intomainfrom
bz/author-only-locate-floor

Conversation

@BugenZhao
Copy link
Owner

Summary

  • add a Swift-side TopicPostLocator that caches full-topic post locations and scans full-topic pages on demand when author-only needs to resolve a post back to its real floor
  • wire Locate This Floor through topic details and reply-chain navigation so author-only can dismiss back to the originating topic and jump to the matching full-topic post
  • keep author-only floor display unchanged while seeding locator state from loaded full-topic replies only

Testing

  • make swiftformat
  • make build
  • AXe manual verification on mnga://topic/45315204
    • enter This Author Only
    • open author-only reply menu and tap Locate This Floor
    • confirm it returns to the original topic and lands on the post's real full-topic floor

Copilot AI review requested due to automatic review settings March 15, 2026 03:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Swift-side mechanism to “locate” an author-only reply’s corresponding floor in the full topic, enabling navigation back to the originating topic and scrolling/loading the correct page when needed.

Changes:

  • Introduces TopicPostLocator to cache post locations and scan topic pages on demand to resolve a post’s full-topic floor/page.
  • Wires a Locate This Floor action through topic details, author-only topic navigation, and reply-chain navigation.
  • Seeds locator state from loaded full-topic replies (while keeping author-only floor display unchanged).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
app/Shared/Views/TopicDetailsView.swift Adds locator state + callback plumbing; seeds locator from topic responses; adds locate/jump helpers and navigation wiring.
app/Shared/Views/PostReplyChainView.swift Passes locate callback through author-only navigation destination.
app/Shared/Models/TopicPostLocator.swift New model to cache/scan full-topic pages to resolve a post’s page/floor location.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BugenZhao BugenZhao merged commit 4cc74c7 into main Mar 15, 2026
2 checks passed
@BugenZhao BugenZhao deleted the bz/author-only-locate-floor branch March 15, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants