Skip to content

implemented testing #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VinceWilliamsDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implemented testing #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const cors = require("cors");

const authRouter = require("../auth/auth-router");
const storiesRouter = require("../stories/stories-router");
const protected = require("../auth/auth-mw/protectedContent");
const protectedContent = require("../auth/auth-mw/protectedContent");

const server = express();

Expand All @@ -14,7 +14,7 @@ server.use(express.json());
server.use(cors());

server.use("/api/auth", authRouter);
server.use("/api/stories", protected, storiesRouter);
server.use("/api/stories", protectedContent, storiesRouter);

server.get("/", (req, res) => {
res.json({ api: "up" });
Expand Down
300 changes: 300 additions & 0 deletions api/server.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,300 @@
const server = require("./server.js");
const request = require("supertest");
const db = require("../database/dbconfig");

//////////////////////////// AUTH ENDPOINT ///////////////////////////////

describe("The users route handles user type requests", () => {
beforeEach(async () => {
await db("Users").truncate();
});

describe("The register endpoint adds new users to the database", () => {
it("adds user to the database, ", async () => {
await request(server).post("/api/auth/register").send({
username: "Bob",
password: "password",
email: "email@email.com",
});

const user = await db("Users");

expect(user).toHaveLength(1);
});

it("does not crash if supplied extraneous data", async () => {
await request(server).post("/api/auth/register").send({
username: "Bob",
password: "password",
email: "email@email.com",
otherData: "Something else",
});

const user = await db("Users");

expect(user).toHaveLength(1);
});

it("requires username in the request", async () => {
const response = await request(server).post("/api/auth/register").send({
password: "password",
email: "email@email.com",
});

expect(response.statusCode).toBe(400);
});
});

describe("The login endpoint allows users to log in", () => {
it("returns a token when correct credentials are supplied", async () => {
await request(server).post("/api/auth/register").send({
username: "Bob",
password: "password",
email: "email@email.com",
});

const response = await request(server).post("/api/auth/login").send({
username: "Bob",
password: "password",
});

expect(response.body.token).toBeTruthy();
});

it("does not allow users with invalid credentials to log in", async () => {
const response = await request(server).post("/api/auth/login").send({
username: "Bob",
password: "password",
});

expect(response.statusCode).toBe(401);
});
});
});

/////////////////////////// STORIES ENDPOINT ////////////////////////////////

describe("The stories endpoint successfully handles data requests", () => {
let token = "";

beforeEach(async () => {
await db("Users").truncate();
await db("Stories").truncate();

await request(server).post("/api/auth/register").send({
username: "Bob",
password: "password",
email: "email@email.com",
});

const response = await request(server).post("/api/auth/login").send({
username: "Bob",
password: "password",
});

token = response.body.token;
});

describe("the stories endpoint allows the user to upload a story", () => {
//////// POST ////////
describe("testing POST requests", () => {
it("/stories requires a token", async () => {
//no token set in auth header
const response = await request(server).post("/api/stories").send({
user_id: "1",
title: "Title of adventure",
body: "This is a story about my adventure.",
});

expect(response.statusCode).toBe(401);
});

it("accepts a story with author's id, title, body", async () => {
const response = await request(server)
.post("/api/stories")
.set("Authorization", token)
.send({
user_id: "1",
title: "Title of adventure",
body: "This is a story about my adventure.",
});

expect(response.statusCode).toBe(201);
expect(response.type).toBe("application/json");
});

it("accepts a story with location and image_url as optional fields", async () => {
const response = await request(server)
.post("/api/stories")
.set("Authorization", token)
.send({
user_id: "1",
title: "Title of adventure",
body: "This is a story about my adventure.",
location: "The woods",
image_url:
"https://images.unsplash.com/photo-1542359649-31e03cd4d909?ixlib=rb-1.2.1&ixid=eyJhcHBfaWQiOjEyMDd9&auto=format&fit=crop&w=500&q=60",
});

expect(response.statusCode).toBe(201);
expect(response.type).toBe("application/json");
});
});
});

///////////// GET ///////////////////////
describe("Testing GET requests", () => {
it("/stories requires a token", async () => {
//no token set in auth header
const response = await request(server).get("/api/stories");

expect(response.statusCode).toBe(401);
});

it("returns an array of stories", async () => {
await request(server)
.post("/api/stories")
.set("Authorization", token)
.send({
user_id: "1",
title: "Title of adventure",
body: "This is a story about my adventure.",
location: "The woods",
image_url:
"https://images.unsplash.com/photo-1542359649-31e03cd4d909?ixlib=rb-1.2.1&ixid=eyJhcHBfaWQiOjEyMDd9&auto=format&fit=crop&w=500&q=60",
});

const response = await request(server)
.get("/api/stories")
.set("Authorization", token);

expect(response.statusCode).toBe(200);
expect(response.type).toBe("application/json");
});
});

describe("GET by story id returns the story with that id", () => {
it("/stories/storyId/:id requires a token", async () => {
//no token set in auth header
const response = await request(server).get("/api/stories/storyId/1");

expect(response.statusCode).toBe(401);
});

it("returns the specified story", async () => {
await request(server)
.post("/api/stories")
.set("Authorization", token)
.send({
user_id: "1",
title: "Title of adventure",
body: "This is a story about my adventure.",
location: "The woods",
image_url:
"https://images.unsplash.com/photo-1542359649-31e03cd4d909?ixlib=rb-1.2.1&ixid=eyJhcHBfaWQiOjEyMDd9&auto=format&fit=crop&w=500&q=60",
});

const response = await request(server)
.get("/api/stories/storyId/1")
.set("Authorization", token);

expect(response.statusCode).toBe(200);
expect(response.type).toBe("application/json");
expect(response.body[0].id).toBe(1);
});
});

describe("GET by user id returns an array of stories by that user", () => {
it("/stories/user/:id requires a token", async () => {
//no token set in auth header
const response = await request(server).get("/api/stories/user/1");

expect(response.statusCode).toBe(401);
});

it("returns the specified user's stories", async () => {
await request(server)
.post("/api/stories")
.set("Authorization", token)
.send({
user_id: "1",
title: "Title of adventure",
body: "This is a story about my adventure.",
location: "The woods",
image_url:
"https://images.unsplash.com/photo-1542359649-31e03cd4d909?ixlib=rb-1.2.1&ixid=eyJhcHBfaWQiOjEyMDd9&auto=format&fit=crop&w=500&q=60",
});

const response = await request(server)
.get("/api/stories/user/1")
.set("Authorization", token);

expect(response.statusCode).toBe(200);
expect(response.type).toBe("application/json");
expect(response.body[0].user_id).toBe(1);
});
});

/////////////////// PUT ///////////////////////
describe("Testing PUT requests", () => {
it("returns the updated story", async () => {
await request(server)
.post("/api/stories")
.set("Authorization", token)
.send({
user_id: "1",
title: "Title of adventure",
body: "This is a story about my adventure.",
location: "The woods",
image_url:
"https://images.unsplash.com/photo-1542359649-31e03cd4d909?ixlib=rb-1.2.1&ixid=eyJhcHBfaWQiOjEyMDd9&auto=format&fit=crop&w=500&q=60",
});

const response = await request(server)
.put("/api/stories/1")
.set("Authorization", token)
.send({
user_id: "1",
//new title
title: "This is a new title",
body: "This is a story about my adventure.",
location: "The woods",
image_url:
"https://images.unsplash.com/photo-1542359649-31e03cd4d909?ixlib=rb-1.2.1&ixid=eyJhcHBfaWQiOjEyMDd9&auto=format&fit=crop&w=500&q=60",
});

expect(response.statusCode).toBe(200);
expect(response.type).toBe("application/json");
expect(response.body[0].title).toBe("This is a new title");
});
});

/////////////////// DELETE ///////////////////////
describe("Testing DELETE requests", () => {
it("deletes the specified story", async () => {
const postResponse = await request(server)
.post("/api/stories")
.set("Authorization", token)
.send({
user_id: "1",
title: "Title of adventure",
body: "This is a story about my adventure.",
location: "The woods",
image_url:
"https://images.unsplash.com/photo-1542359649-31e03cd4d909?ixlib=rb-1.2.1&ixid=eyJhcHBfaWQiOjEyMDd9&auto=format&fit=crop&w=500&q=60",
});

const deleteResponse = await request(server)
.delete("/api/stories/1")
.set("Authorization", token);

const confirmDelete = await request(server)
.get("/api/stories/storyId/1")
.set("Authorization", token);

expect(postResponse.statusCode).toBe(201);
expect(postResponse.type).toBe("application/json");
expect(deleteResponse.statusCode).toBe(204);
});
});
});
35 changes: 35 additions & 0 deletions auth/auth-mw/requireEmail.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
const requireEmail = require("./requireEmail");
const httpMock = require("node-mocks-http");

describe("testing requireEmail()", () => {
it("returns error message if email is not in body", () => {
const mockReq = httpMock.createRequest({
body: {email: ""},
});

const mockRes = httpMock.createResponse();
const mockNext = jest.fn(() => true);

// run the function under test
const response = requireEmail(mockReq, mockRes, mockNext);

// Pull the data out of response
const data = response._getJSONData();

expect(response.statusCode).toBe(400);
expect(data.message).toBe("Missing required email field");
});

it("returns next() if the email is present", () => {
const mockReq = httpMock.createRequest({
body: {email: "email@email.com"},
});

const mockRes = httpMock.createResponse();
const mockNext = jest.fn(() => true);

const response = requireEmail(mockReq, mockRes, mockNext);

expect(mockNext).toBeCalled();
});
});
1 change: 0 additions & 1 deletion auth/auth-router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ router.post("/login", validateFields, (req, res) => {
users.selectBy({ username: username }).then(([user]) => {
if (user && bcrypt.compareSync(password, user.password)) {
const token = signToken(user);
console.log(user);
res.json({
userId: user.id,
message: "Login successful",
Expand Down
Loading