StrongID & Splicer Enhancements #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a massive overhaul to Splicer, and templatizes ResourceID into a generic StrongID. In addition to ResourceID, StrongID is now also used to deterministically identify Splicer Snr sample files through SnrID. This allows the same samples from many versions & platforms for the game to have a centralized reference, and makes porting/importing new samples a much easier process. In addition, the splicer format itself now stores its SampleRefs inside each splice, which makes adjusting/adding/removing each splice's sound(s) a simple process.
Once a proper UI is written, this should allow for a fully fledged splicer editor to easily be written.
And I fixed exporting.