Skip to content

Conversation

@JeBobs
Copy link
Collaborator

@JeBobs JeBobs commented Oct 10, 2025

  • refactor resource import/export commands to delegate work to reusable operations for loading and saving resources
  • add a dedicated texture porting operation and simplify the PortTexture CLI command to invoke it
  • introduce string table operations for loading, merging, and persisting ResourceDB data and update the command to use them

@JeBobs JeBobs marked this pull request as ready for review December 23, 2025 07:26
@JeBobs JeBobs merged commit fd93287 into main Dec 23, 2025
7 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +159 to +163
outPath = $"{Path.GetDirectoryName(resolvedDestinationPath)}{Path.DirectorySeparatorChar}{outResourceFilename}";
}
else if (new DirectoryInfo(resolvedDestinationPath).Exists)
{
outPath = resolvedDestinationPath + Path.DirectorySeparatorChar + outResourceFilename;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Handle file outpaths when porting textures

The new SetArgs fixes --outpath so callers can pass a file path, but PortTextureOperation still only sets outPath when the destination is the source file or an existing directory. If the user supplies a valid file path (per the CLI contract allowing file/folder paths), the branch at lines 159‑163 leaves outPath empty and the subsequent bitmap copy and file writes throw because they try to write to an empty path. This regression makes porting fail whenever --outpath targets a specific file instead of a directory.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants