Skip to content

Conversation

@Byloth
Copy link
Owner

@Byloth Byloth commented Sep 11, 2024

This is work in progress...

As the user Mein Name ist Hase stated on the CMaNGOS official server:

TBC playerbots are currently incompatible with the LFG changes
When/if that gets fixed it should work again


Until then, this PR is blocked.

@Byloth Byloth closed this Oct 1, 2024
@Byloth Byloth deleted the feature/bots branch October 1, 2024 09:08
@Byloth Byloth restored the feature/bots branch October 1, 2024 09:09
@Byloth Byloth reopened this Oct 1, 2024
@Byloth Byloth linked an issue Oct 4, 2024 that may be closed by this pull request
@mserajnik
Copy link
Contributor

mserajnik commented Jan 25, 2026

Hey, has there been any update to this (specifically about TBC support)? I don't use Discord, so I sadly can't check the linked statement. 😄

@Byloth
Copy link
Owner Author

Byloth commented Jan 28, 2026

Hi, @mserajnik.

Here's their reply:
image


It's probably time to definitely merge this PR.
I'll work on this on the next weeks.

@mserajnik
Copy link
Contributor

It's probably time to definitely merge this PR.
I'll work on this on the next weeks.

Is there anything in particular left to do you could use help with?

A bit unrelated: I have noticed you are only including quite minimalistic config files as opposed to the full default CMaNGOS configs. Is there a particular reason for that? Of course, I understand not wanting to visually expose settings that shouldn't be changed manually by the user (when changing them would mean breaking the Docker setup), but there are a lot of things that might be desirable to adjust (mostly gameplay-related stuff) that should work without causing any issues (e.g., in mangosd.conf, but also in aiplayerbot.conf and the other files).

@Byloth
Copy link
Owner Author

Byloth commented Jan 29, 2026

@mserajnik:
I have noticed you are only including quite minimalistic config files as opposed to the full default CMaNGOS configs.
Is there a particular reason for that?

Yeah, actually yes!

Not because I'm afraid of exposing configurations that might be edited by someone causing issue...
Everyone should be able of doing whatever they want, on their servers, I think...

But - actually - because CMaNGOS Docker has a smart "replacing & overriding" settings behaviour...
It uses the default settings and let you simply change the ones you don't like.

Here's a simple explanation for that: https://github.com/Byloth/cmangos-docker/wiki/server-configuration#configuration-file


Of course, you can copy & paste all the servers configurations in those files: so you can be sure to use a complete list.
It doesn't matter if your settings are equal to the default ones. It would work in any case.

@mserajnik
Copy link
Contributor

Here's a simple explanation for that: https://github.com/Byloth/cmangos-docker/wiki/server-configuration#configuration-file

Ah, thanks for this, I missed that.

I think this approach is fine. I guess the vast majority of people runs default settings anyway; and "forcing" those who want to adjust things to do some research about what is possible on their own is not a bad idea either. 😄

@Byloth
Copy link
Owner Author

Byloth commented Feb 2, 2026

Related to #38.

@Byloth Byloth linked an issue Feb 2, 2026 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Improve the configuration files handling Is there support for AHBot and Playerbots?

2 participants