Fix query-string bug in list.models() + introduce unit testing#42
Open
Adwaitbytes wants to merge 3 commits intoBytez-com:mainfrom
Open
Fix query-string bug in list.models() + introduce unit testing#42Adwaitbytes wants to merge 3 commits intoBytez-com:mainfrom
Adwaitbytes wants to merge 3 commits intoBytez-com:mainfrom
Conversation
Extract query building into testable utility using URLSearchParams. Fixes malformed URLs when both task and modelId filters are provided. Before: list/models?task=chat?modelId=gpt2 After: list/models?task=chat&modelId=gpt2
Introduces test:unit script and comprehensive test coverage for buildListModelsPath utility. Tests verify empty/undefined options, single parameter, multiple parameters with ampersand joining, and special character encoding. Tests run in under 1 second without API key or HTTP mocking.
Documents development setup for all SDKs, unit vs integration test philosophy, and PR guidelines. Establishes testing expectations for future contributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the issue?
While exploring the JavaScript SDK, I noticed that using both
taskandmodelIdfilters together inlist.models()produces malformed URLs:The string concatenation approach creates double question marks instead of properly joining parameters with
&. This could lead to 400 errors or unexpected API responses that are confusing to debug.What changed?
Fixed the bug:
URLSearchParamsfor proper parameter joining and encoding/in model IDs) now get properly encodedAdded testing:
npm run test:unitfor fast feedback during developmentImproved contributor experience:
CONTRIBUTING.mdwith dev setup instructions and testing guidelinesWhy this approach?
I considered a few alternatives:
Extracting to a pure function means we can test the logic directly without any network calls or complex mocking. The tests are fast and cover edge cases that would be easy to miss.
Testing
Impact