Open
Conversation
C-Hipple
pushed a commit
that referenced
this pull request
Mar 5, 2026
Reviews SetFeedback handler design, missing Feedback fields in reply types, stale feedback after submission, and frontend UX issues. https://claude.ai/code/session_018PuhqsLkBRPTvUKBzYiqy4
C-Hipple
pushed a commit
that referenced
this pull request
Mar 8, 2026
- Add GetFeedback and DeleteFeedback methods to database.go - Make SetFeedbackReply lightweight (Okay bool only); drop unused ID field and remove expensive fetchPRAndRunPlugins call from SetFeedback - Add fetchFeedback helper on RPCHandler that logs errors instead of silently discarding them - Add Feedback field to GetPRReply, SyncPRReply, AddCommentReply, EditCommentReply, DeleteCommentReply, and SubmitReviewReply so all PR response types carry the feedback draft consistently - Delete feedback draft from DB after SubmitReview succeeds, mirroring the local-comment cleanup that already happens post-submission https://claude.ai/code/session_018PuhqsLkBRPTvUKBzYiqy4
Adds a "Review Feedback" panel below the diff in the web UI that allows users to write and persist a PR-level comment body (equivalent to the Emacs client's `crs-set-review-feedback`). The feedback is saved to the server via `RPCHandler.SetFeedback` and pre-populated into the Submit Review modal body when opened. Server changes: - Add `GetFeedback` DB method to read persisted feedback for a PR - Add `Feedback string` field to `GetPRReply` and `SyncPRReply`, populated from the DB on each GetPR/SyncPR call Client changes: - Add `feedbackBody` state loaded from `GetPR`/`SyncPR` responses - Add `handleSaveFeedback` handler calling `RPCHandler.SetFeedback` - Add Review Feedback panel with textarea and Save Feedback button - Pre-fill Submit Review modal body from `feedbackBody` on open https://claude.ai/code/session_01Cjnt5SUXETenCrGHrNEhPz
C-Hipple
force-pushed
the
claude/add-pr-comments-UkEV2
branch
from
ddc8aab to
0a89f03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for persisting PR-level review feedback that can be saved independently and pre-filled when submitting a review. This allows users to draft and save overall review comments before formally submitting a review.
Changes
feedbackfield toPRResponseinterface to include PR-level feedback in API responsesGetFeedback()database method to retrieve saved feedback for a PRGetPRandSyncPRRPC handlers to include feedback in responseshandleSaveFeedback()to persist feedback viaRPCHandler.SetFeedbackRPC callTest Plan
go build ./...passesgo test ./...passeshttps://claude.ai/code/session_01Cjnt5SUXETenCrGHrNEhPz