Fix PR metadata cache overwrite with incomplete review data#72
Open
Fix PR metadata cache overwrite with incomplete review data#72
Conversation
1. Merge Reviews and Commits fields in prefetchAuxData requirement accumulation. Previously only Comments, CIStatus, and Diff were ORed together across workflows for the same PR; Reviews and Commits were silently ignored, so whether they got fetched depended on map iteration order. 2. Guard buildAndCacheMetadata on reviewsFetched. When reviews were not requested, ghReviews is nil and the metadata cache was being written with empty approved_by/changes_requested_by/commented_by fields, overwriting any previously-cached review state. Now the metadata write is skipped unless reviews were actually fetched. https://claude.ai/code/session_01D3cDggRWmeTdA1vZsgZNVs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where PR metadata cache entries were being overwritten with incomplete review data when workflows didn't request review information. This caused previously-cached review state (approved_by, changes_requested_by) to be lost.
Changes
ReviewsandCommitsfields to the auxiliary data merge logic inprefetchAuxDatato properly track which data was fetchedreq.Reviewsflag topersistPRCacheDatato indicate whether reviews were actually requestedreviewsFetchedparameter and its purposeTest Plan
go build ./...passesgo test ./...passeshttps://claude.ai/code/session_01D3cDggRWmeTdA1vZsgZNVs