Add PR-level review feedback persistence to API responses#82
Open
Add PR-level review feedback persistence to API responses#82
Conversation
Reviews SetFeedback handler design, missing Feedback fields in reply types, stale feedback after submission, and frontend UX issues. https://claude.ai/code/session_018PuhqsLkBRPTvUKBzYiqy4
- Add GetFeedback and DeleteFeedback methods to database.go - Make SetFeedbackReply lightweight (Okay bool only); drop unused ID field and remove expensive fetchPRAndRunPlugins call from SetFeedback - Add fetchFeedback helper on RPCHandler that logs errors instead of silently discarding them - Add Feedback field to GetPRReply, SyncPRReply, AddCommentReply, EditCommentReply, DeleteCommentReply, and SubmitReviewReply so all PR response types carry the feedback draft consistently - Delete feedback draft from DB after SubmitReview succeeds, mirroring the local-comment cleanup that already happens post-submission https://claude.ai/code/session_018PuhqsLkBRPTvUKBzYiqy4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires up the existing
Feedbackdatabase table to the RPC API by adding feedback retrieval and persistence across multiple PR-related endpoints. This allows the frontend to save and restore draft review feedback for pull requests.Changes
Feedbackfield to reply types:GetPRReply,AddCommentReply,EditCommentReply,DeleteCommentReply,SubmitReviewReply, andSyncPRReplyfetchFeedback()helper method to retrieve saved feedback with error loggingGetPR,AddComment,EditComment,DeleteComment,SubmitReview,SyncPR) to populate feedback in responsesSetFeedbackhandler to return lightweight{ okay bool }response instead of full PR dataGetFeedback()andDeleteFeedback()database methods with proper error handlingTest Plan
go build ./...passesgo test ./...passeshttps://claude.ai/code/session_018PuhqsLkBRPTvUKBzYiqy4