Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
NonprofitDocumentwas storing raw file bytes in afileData Bytescolumn. So we now store the reference to where the file is located with the newfilePathcolumn. Existing records are left the same and that flow is fine but new files going forward will have thefilePathcolumn populated instead offileData.Two storage paths
fileDatafilePathNULLNULLThe download endpoint handles both transparently
Key changes
Database
fileDatamade optional (Bytes?) existing rows left samefilePath String?addedNULLon all existing rowsAPI
GET /api/nonprofit-documentslist endpoint, returns metadata onlyGET /api/nonprofit-documents/download?id=new dedicated download endpoint; checksfilePathfirst, falls back tofileDatafor legacy recordsPOST /api/nonprofit-documentswrites to disk, storesfilePath, clearsfileDataon updatePATCH /api/nonprofit-documentssame as POST; also deletes the old file from disk when replacingOther
docker-compose.yml—uploads/directory mounted as a named volume so files survive container restarts