Skip to content

Conversation

@ZaHgO
Copy link

@ZaHgO ZaHgO commented Sep 7, 2025

Overview

Modified alphabet to include images with extension .bmp and .jpg.
Added test case for checking only files with the correct extensions are included.

Ticket

Link a pivotal ticket here

Contributions

  • Modified alphabet to include images with extension .bmp and .jpg.
  • Added test case for checking only files with the correct extensions ares included.

Test

  • Run unit test python -m unittest bcipy/core/tests/test_symbols.py
  • Modified parameters to to point to a folder with bmp images and executed 'python bcipy/demo/bci_main_demo.py'. Images were displayed correctly.

Documentation

  • Updated helpTip for path_to_presentation_images in bcipy/parameters/parameters.json

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? No

@tab-cmd tab-cmd changed the base branch from main to 2.0.1 September 8, 2025 20:37
@celikbasak celikbasak self-requested a review September 8, 2025 20:38
@tab-cmd
Copy link
Contributor

tab-cmd commented Sep 8, 2025

@ZaHgO Thank you for this addition!

I changed the base branch to prepare for a minor patch release that will include a few other items over the next week or so. I'll have @celikbasak review the content!

Please let us know if you'd like an invitation to the BciPy Discord. Several of us are there to answer questions or share resources. If you do have questions or need to report a bug, you can do so here (GitHub Issues) or through Discord.

@tab-cmd
Copy link
Contributor

tab-cmd commented Sep 8, 2025

@celikbasak, you will have to run the unittests etc. locally. The builds are failing due to a psychopy change. I'm working on a fix to include with the patch now!

psychopy/psychopy#7384

@ZaHgO
Copy link
Author

ZaHgO commented Sep 9, 2025

@ZaHgO Thank you for this addition!

I changed the base branch to prepare for a minor patch release that will include a few other items over the next week or so. I'll have @celikbasak review the content!

Please let us know if you'd like an invitation to the BciPy Discord. Several of us are there to answer questions or share resources. If you do have questions or need to report a bug, you can do so here (GitHub Issues) or through Discord.

Thanks. Sure, I'd like an invite.

@tab-cmd tab-cmd merged commit cf4667d into CAMBI-tech:2.0.1 Sep 15, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants