Add ReadFileRawDiskAccess and modify bootkit sigs

[kevross33]

added sig for reading from harddrive and also modified the writing to drive sigs to use APIs to allow more visibility/analysis on what is being done and also to handle deviceiocontrol potentially writing to it/modifying it via control codes.

HermeticWiper

[gemini-code-assist]

Summary of Changes

Hello @kevross33, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new security signature aimed at enhancing the detection of advanced threats such as bootkits and wipers. By specifically identifying NtReadFile operations directed at raw physical disk devices, the system can now better recognize malicious activity that attempts to bypass standard file system protections and gain low-level access to disk data.

Highlights

• New Signature for Raw Disk Access: Added a new signature, ReadFileRawDiskAccess, to detect NtReadFile calls targeting raw physical disk devices (e.g., \Device\Harddisk). This behavior is characteristic of bootkits or wipers attempting to bypass standard file system protections.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• modules/signatures/windows/bootkit.py
  • Added a new signature class ReadFileRawDiskAccess to identify raw disk read operations.

Activity

• No specific activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new signature ReadFileRawDiskAccess to detect raw disk access attempts. The implementation is sound, but I've suggested a couple of improvements. The main one is to make the path check case-insensitive to improve detection accuracy. I've also pointed out some minor style issues like removing a leftover comment and trailing whitespace to improve code quality.