BETTER debugging and general Improvements#6
Open
Marcial1234 wants to merge 1 commit intoCEN3031-spr16:masterfrom
Open
BETTER debugging and general Improvements#6Marcial1234 wants to merge 1 commit intoCEN3031-spr16:masterfrom
Marcial1234 wants to merge 1 commit intoCEN3031-spr16:masterfrom
Conversation
Marcial1234
force-pushed
the
master
branch
2 times, most recently
from
236a6af to
25eb396
Compare
Marcial1234
changed the title
Marcial1234
commented
Sep 10, 2017
|
|
||
| # configuration files | ||
| server/config/config.js | ||
| config.js |
Marcial1234
commented
Sep 10, 2017
| var app = express(); | ||
|
|
||
| // Readable JSON output | ||
| app.set('json spaces', 4); |
Author
There was a problem hiding this comment.
Better JSON output. Although not necessarily need, better for general debugging JSON
Marcial1234
commented
Sep 10, 2017
| } else { | ||
| req.results = undefined | ||
| console.log(data); | ||
| } |
Author
There was a problem hiding this comment.
The above is the main reason for this PR (see whole file diff)
Marcial1234
commented
Sep 10, 2017
| /* Remove the article */ | ||
| /* Remove the listing */ | ||
| }; | ||
|
|
|
you're so extra, Marcial lol |
HarryGogonis
approved these changes
Sep 13, 2017
Author
|
Merge in maybe? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
I spent about an hour or so trying to figure out what was wrong with the Google Maps API. This PR adds logging instructions in case of no API key or general errors with the API.
TODO