Skip to content
This repository was archived by the owner on Feb 28, 2022. It is now read-only.

[ci skip] WIP: Refactoring for Invenio-Videos#41

Open
egabancho wants to merge 1 commit intoCERNDocumentServer:masterfrom
egabancho:object-oriented-refactoring
Open

[ci skip] WIP: Refactoring for Invenio-Videos#41
egabancho wants to merge 1 commit intoCERNDocumentServer:masterfrom
egabancho:object-oriented-refactoring

Conversation

@egabancho
Copy link
Member

@egabancho egabancho commented Apr 24, 2018

@egabancho egabancho requested review from ntarocco and switowski April 24, 2018 14:16
@egabancho egabancho force-pushed the object-oriented-refactoring branch 2 times, most recently from 7f1b606 to 681c81d Compare April 27, 2018 12:43
@egabancho egabancho force-pushed the object-oriented-refactoring branch from 681c81d to 867ca45 Compare April 27, 2018 21:04
CDS_SORENSON_BIG_FILE_THRESHOLD = 21474836480 # 20 Gb
"""Size after which a file is consider big.

Sorenson machines are heterogeneous, two machines have a big disk (1Tb) and the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR: here you describe the specific CERN config, I don't know if you want to be more generic here and document this in our doc maybe


CDS_SORENSON_QUEUES = {
'default': '88b51dfc-fa33-4d0e-8ea0-934fc31dc4a2',
'big_files': '064153dd-ade2-4824-8458-88e6ea03d395',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these the right queues ids already?

Copy link
Member Author

@egabancho egabancho May 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, I took them from the issue I opened some time ago #39

@ntarocco
Copy link
Contributor

ntarocco commented May 4, 2018

Question: I see it is WIP, and it is missing code, right? It is not just waiting for tests or other...

@egabancho
Copy link
Member Author

Yeap, it's still missing some parts, i.e. TODO, and still have to figure out some others, but if you want to take a look I'll be gratefull!
Plus it's missing tests ☺️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants