Skip to content

player: add keyboard shortcuts#2160

Merged
zzacharo merged 2 commits intoCERNDocumentServer:mainfrom
zubeydecivelek:player-keyboard
Feb 16, 2026
Merged

player: add keyboard shortcuts#2160
zzacharo merged 2 commits intoCERNDocumentServer:mainfrom
zubeydecivelek:player-keyboard

Conversation

@zubeydecivelek
Copy link
Contributor

@zubeydecivelek zubeydecivelek commented Feb 13, 2026

Added keyboard shortcuts for THEOplayer

  • Space – play / pause
  • ← / → – seek backward / forward (5 s)
  • ↑ / ↓ – volume up / down
  • F – toggle fullscreen
  • M – mute / unmute
  • C – toggle subtitles

setuptools 82 removed pkg_resources see: https://setuptools.pypa.io/en/stable/history.html

zzacharo
zzacharo previously approved these changes Feb 16, 2026
Copy link
Contributor

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's test this out on sandbox before we deploy prod!

@zubeydecivelek
Copy link
Contributor Author

@zzacharo I saw this PR:#2125

Instead of doing "setuptools<82" maybe we can merge that one?

@zzacharo
Copy link
Contributor

@zzacharo I saw this PR:#2125

Instead of doing "setuptools<82" maybe we can merge that one?

But is seems tests are failing on that one no?

@zubeydecivelek
Copy link
Contributor Author

@zzacharo I saw this PR:#2125
Instead of doing "setuptools<82" maybe we can merge that one?

But is seems tests are failing on that one no?

I guess some invenio modules are also using the pkg_resources. I think we can merge this one for now WDYT?

And do you think it's a problem when building the docker image? @zzacharo

@zzacharo
Copy link
Contributor

@zzacharo I saw this PR:#2125
Instead of doing "setuptools<82" maybe we can merge that one?

But is seems tests are failing on that one no?

I guess some invenio modules are also using the pkg_resources. I think we can merge this one for now WDYT?

And do you think it's a problem when building the docker image? @zzacharo

it should not :)

@zzacharo zzacharo merged commit b587f4a into CERNDocumentServer:main Feb 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants