Enhancement/various filetypes#69
Open
r1d3th3wav3s wants to merge 25 commits intoCERT-Polska:masterfrom
Open
Conversation
Contributor
r1d3th3wav3s
commented
Jul 10, 2023
r1d3th3wav3s
commented
- Improved logging
- Adds detection of various file types
- Improved detection of UTF-8 / ASCII files
- Adds a unit test for UTF-8 files
psrok1
reviewed
Sep 7, 2023
Member
psrok1
left a comment
psrok1
left a comment
There was a problem hiding this comment.
It would be nice if you also provide test files for added extensions: see https://github.com/CERT-Polska/karton-classifier/tree/master/tests/testdata
PS.: I've fixed few simple errors and linting + merged it with upstream changes, so please make a pull before applying yours.
* Fix apk classification
Contributor
Author
|
updated my pull request (removed some too specific detections, added unit-tests9 |
nazywam
reviewed
Nov 6, 2023
nazywam
approved these changes
Nov 6, 2023
Member
nazywam
left a comment
nazywam
left a comment
There was a problem hiding this comment.
LGTM
One small note - I think we should stick to - instead of _ in the "kind" fields. There isn't an official guide per se but looking at other filetypes we've used only - so far
nazywam
reviewed
Nov 9, 2023
nazywam
reviewed
Nov 9, 2023
nazywam
reviewed
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.