Skip to content

fix(frontend/activity_timeline): use SI prefixes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xsedla1o merged 1 commit into from
Oct 1, 2025
Merged

fix(frontend/activity_timeline): use SI prefixes #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions frontend/src/components/ActivityTimeline.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import 'chartjs-adapter-date-fns'
import {
CHART_COMMON_OPTIONS,
CHART_SCALE_X_OPTIONS,
formatSI,
resampleTimedData,
setChartDatetimeRange,
} from '@/utils/commonCharts.js'
Expand Down Expand Up @@ -64,7 +65,7 @@ const chartOptions = computed(() => {
x: scaleXOptions,
packets: {
ticks: {
callback: (v) => `${v} ${CHART_UNITS[0]}`,
callback: (v) => formatSI(v, CHART_UNITS[0]),
color: CHART_COLORS[0],
},
grid: { tickColor: CHART_COLORS[0], drawOnChartArea: false },
Expand All @@ -73,7 +74,7 @@ const chartOptions = computed(() => {
},
flows: {
ticks: {
callback: (v) => `${v} ${CHART_UNITS[1]}`,
callback: (v) => formatSI(v, CHART_UNITS[1]),
color: CHART_COLORS[1],
},
grid: { tickColor: CHART_COLORS[1], drawOnChartArea: false },
Expand All @@ -82,7 +83,7 @@ const chartOptions = computed(() => {
},
bytes: {
ticks: {
callback: (v) => `${v} ${CHART_UNITS[2]}`,
callback: (v) => formatSI(v, CHART_UNITS[2]),
color: CHART_COLORS[2],
},
grid: { tickColor: CHART_COLORS[2] },
Expand All @@ -96,7 +97,7 @@ const chartOptions = computed(() => {
callbacks: {
label: (item) => {
let unit = CHART_UNITS[item.datasetIndex]
return `${item.formattedValue} ${unit}`
return formatSI(item.parsed.y, unit, 2)
},
},
usePointStyle: true,
Expand Down
27 changes: 27 additions & 0 deletions frontend/src/utils/commonCharts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,30 @@ export function resampleTimedData(data, dtKey, unitCount, unit, reduceFn, addEmp
// Ensure correct order of buckets
return result.sort((a, b) => a[dtKey] - b[dtKey])
}

/**
* Formats a number using SI prefixes (k, M, G, ...)
*
* Values < 1e3 are not formatted.
*
* @param {Number} value Value to format
* @param {String} unit Unit to append to the formatted value (e.g. 'B', 'Hz')
* @param {Number} decimalPlaces Number of decimal places to show (only for values
* >= 1e3). Default is 1.
* @returns {String} Formatted string
*/
export function formatSI(value, unit = '', decimalPlaces = 1) {
const absValue = Math.abs(value)
if (absValue < 1e3) return `${value} ${unit}`

const units = ['', 'k', 'M', 'G', 'T', 'P', 'E', 'Z', 'Y']
let i = 0
let formattedValue = value

while (i < units.length - 1 && Math.abs(formattedValue) >= 1e3) {
formattedValue /= 1e3
i++
}

return `${formattedValue.toFixed(decimalPlaces)} ${units[i]}${unit}`
}